wrong interface prefix ovs

[Aaron Rosen]

In the openvswitch plugin there is currently code that does:

port_name = 'tap%s' % details['port_id'][0:11]

This is not always correct since all devices don't start with tap when the L3 stuff is added.

Traceback (most recent call last):
  File "/opt/stack/quantum/quantum/plugins/openvswitch/agent/ovs_quantum_agent.py", line 863, in <module>
    main()
  File "/opt/stack/quantum/quantum/plugins/openvswitch/agent/ovs_quantum_agent.py", line 857, in main
    plugin.daemon_loop(db_connection_url)
  File "/opt/stack/quantum/quantum/plugins/openvswitch/agent/ovs_quantum_agent.py", line 823, in daemon_loop
    self.rpc_loop()
  File "/opt/stack/quantum/quantum/plugins/openvswitch/agent/ovs_quantum_agent.py", line 810, in rpc_loop
    sync = self.process_network_ports(port_info)
  File "/opt/stack/quantum/quantum/plugins/openvswitch/agent/ovs_quantum_agent.py", line 767, in process_network_ports
    resync_a = self.treat_devices_added(port_info['added'])
  File "/opt/stack/quantum/quantum/plugins/openvswitch/agent/ovs_quantum_agent.py", line 735, in treat_devices_added
    port = self.int_br.get_vif_port(port_name)
  File "/opt/stack/quantum/quantum/agent/linux/ovs_lib.py", line 225, in get_vif_port
    external_ids = self.db_get_map("Interface", port_name, "external_ids")
  File "/opt/stack/quantum/quantum/agent/linux/ovs_lib.py", line 158, in db_get_map
    str = self.run_vsctl(["get", table, record, column]).rstrip("\n\r")
  File "/opt/stack/quantum/quantum/agent/linux/ovs_lib.py", line 53, in run_vsctl
    return utils.execute(full_args, root_helper=self.root_helper)
  File "/opt/stack/quantum/quantum/agent/linux/utils.py", line 55, in execute
    raise RuntimeError(m)
RuntimeError:
Command: ['sudo', 'ovs-vsctl', '--timeout=2', 'get', 'Interface', 'tapf7e4f1ba-ad', 'external_ids']

[Gary Kotton (garyk)]

https://review.openstack.org/#/c/11456/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/11456

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/11456
Committed: http://github.com/openstack/quantum/commit/044ece27b79c810e6c15131b6a553b649e666678
Submitter: Jenkins
Branch: master

commit 044ece27b79c810e6c15131b6a553b649e666678
Author: Gary Kotton <email address hidden>
Date: Thu Aug 16 06:06:55 2012 -0400

    Get OVS port details from port ID

    Fixes bug 1037443

    This address the issue when a Quantum interface does not start with the
    prefix "tap" (for example interfaces created by the l3 agent)

    Change-Id: Ie2c98940d921606906015914ce6b23d3095e91f2