Inline object creation doesn't redirect to previous modal upon form validation error

Bug #1037302 reported by Kelsey Tripp
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Gabriel Hurley

Bug Description

1. Open modal with inline object creation button (i.e. Create User)
2. Click inline object creation button to bring up new modal/form to create the object (i.e. [+] to add a new primary project)
3. Submit the new object creation form with a required field left blank (i.e. leave the project "Name" field blank and click Finish)
4. The form validation error is shown (i.e. "This field is required.") Fill in the field correctly and re-submit the form.
5. You are redirected to the newly created object's table page (i.e. the Projects page) instead of being returned to the original modal that brought up the form to create the object. Instead, this should work the same way as it does had the form been submitted without validation errors.

Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Gabriel Hurley (gabriel-hurley)
milestone: none → folsom-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/12613

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/12613
Committed: http://github.com/openstack/horizon/commit/8756b3b2ada6f4ff914c2d733a814361d4e62415
Submitter: Jenkins
Branch: master

commit 8756b3b2ada6f4ff914c2d733a814361d4e62415
Author: Gabriel Hurley <email address hidden>
Date: Fri Sep 7 15:41:00 2012 -0700

    Preserve add-to-field after form error.

    Fixes bug 1037302.

    Change-Id: I827f1b74efc6835dfac1fdcdc7c2a7c12af421eb

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.