Add support for extra ops to aggregate_instance_extra_specs filter

Bug #1037090 reported by Mark McLoughlin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Jinwoo "Joseph" Suh

Bug Description

We added extra comparison operators to the extra specs support in compute_capabilities_filter: https://review.openstack.org/8089

This is where we compare the extra specs to the capabilities reported by the hypervisor

However, using host aggregates, we also allow administrators to define per-host properties which extra specs gets matched against. This is handled by the aggregate_instance_extra_specs filter.

We should add the extra operators to the aggregate_instance_extra_specs too.

Being addressed at https://review.openstack.org/#/c/11449/.

Mark McLoughlin (markmc)
Changed in nova:
status: New → Triaged
importance: Undecided → High
milestone: none → folsom-rc1
description: updated
description: updated
Changed in nova:
assignee: nobody → Jinwoo "Joseph" Suh (jsuh)
Changed in nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11449

description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/11832

Revision history for this message
Mark McLoughlin (markmc) wrote :

Joeseph - do you need someone else to take over this issue?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/11449
Committed: http://github.com/openstack/nova/commit/6bc54f4af01126712716682a5e50333bf63ff1a7
Submitter: Jenkins
Branch: master

commit 6bc54f4af01126712716682a5e50333bf63ff1a7
Author: Jinwoo 'Joseph' Suh <email address hidden>
Date: Wed Aug 22 19:59:04 2012 -0400

    Add ops to aggregate_instance_extra_specs filter.

    The following operators on instance_type_extra_specs were added in
    aggregate_instance_extra_specs filter. Fixes bug 1037090.

    = (equal to or greater than as a number; same as vcpus case)
    == (equal to as a number)
    != (not equal to as a number)
    >= (greater than or equal to as a number)
    <= (less than or equal to as a number)
    s== (equal to as a string)
    s!= (not equal to as a string)
    s>= (greater than or equal to as a string)
    s> (greater than as a string)
    s<= (less than or equal to as a string)
    s< (less than as a string)
    <in> (substring)
    <or> (find one of these)

    If the first word in the instance_type_extra_spec is not one of the
    keywords above, a default operator "s==" is used.

    E.g.: ">= 5", "s== 2.1.0", "<in> gcc", and "<or> fpu <or> gpu"

    Change-Id: Iee9bf68011738aab146e6311a17cb3c673d7a392

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-rc1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.