Get the note displayed in a People report for departments

[Paul Everitt]

A minor request from the new OSF President, thus urgent. :)

In the PEOPLE reports, we display a "note" above the grid and below the address information, if that category has a "note" value. This note value comes from GSA.

This works for offices but isn't working for departments. Here is a note that Nat added, for the relevant category, as it is sent to us in GSA XML:

<category id="departments" title="Departments"><category_item><id>1257</id><title>Office of the Chairman</title><hcard><fn>Office of the Chairman</fn><org>Office of the Chairman</org><url/><note>If you are calling from the New York office, dial # then the extension.</note>

Can we store that and get it displayed in the report for the "Office of the Chairman" department?

[Carlos de la Guardia (cguardia)]

The problem is that on the gsa to karl xslt stylesheet, there is a condition that the description for the category will only be generated if either the url, the phone or the fax are set. Since in the sample above they are not, the field is empty.

Should I remove the condition? A copy of the xml file in question would be handy for testing.

While this is done and tested, I can very easily add the note to the "Office of the Chairman" report. I did that here:

https://karlstaging.gocept.com/people/osi/c1/r2/office-of-the-chairman/

Let me know if I should do the same on prod in the morning.

[Paul Everitt (paul-agendaless)]

I forgot, Nat is subscribed to this ticket so we can talk here.

On on hand, we might have put that condition in based on some reason that has been lost in the sands of time. OTOH, I can't think of any good reason not to show a note when there is a note.

I propose:

- We remove the condition and just show the note.

- It goes into testing today on karlstaging.

- If Nat can't find any reports which are now wrong based on this change, we consider it a done deal.

Nat, you available for tire-kicking on karlstaging today? We have a bunch of stuff we plan to put into production tomorrow.

--Paul

On Aug 15, 2012, at 1:08 AM, Carlos de la Guardia wrote:

> The problem is that on the gsa to karl xslt stylesheet, there is a
> condition that the description for the category will only be generated
> if either the url, the phone or the fax are set. Since in the sample
> above they are not, the field is empty.
>
> Should I remove the condition? A copy of the xml file in question would
> be handy for testing.
>
> While this is done and tested, I can very easily add the note to the
> "Office of the Chairman" report. I did that here:
>
> https://karlstaging.gocept.com/people/osi/c1/r2/office-of-the-chairman/
>
> Let me know if I should do the same on prod in the morning.
>
> ** Changed in: karl3
> Status: New => In Progress
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1036853
>
> Title:
> Get the note displayed in a People report for departments
>
> Status in KARL3:
> In Progress
>
> Bug description:
> A minor request from the new OSF President, thus urgent. :)
>
> In the PEOPLE reports, we display a "note" above the grid and below
> the address information, if that category has a "note" value. This
> note value comes from GSA.
>
> This works for offices but isn't working for departments. Here is a
> note that Nat added, for the relevant category, as it is sent to us in
> GSA XML:
>
> <category id="departments"
> title="Departments"><category_item><id>1257</id><title>Office of the
> Chairman</title><hcard><fn>Office of the Chairman</fn><org>Office of
> the Chairman</org><url/><note>If you are calling from the New York
> office, dial # then the extension.</note>
>
> Can we store that and get it displayed in the report for the "Office
> of the Chairman" department?
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/1036853/+subscriptions

[Nat Katin-Borland (nborland)]

Sounds good. Off hand I can't think of any instance where we have a note that shouldn't be displayed, so we should be good there.

I can test after lunch.

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Paul Everitt
Sent: Wednesday, August 15, 2012 7:47 AM
To: Nathaniel Katin-Borland
Subject: Re: [Bug 1036853] Get the note displayed in a People report for departments

I forgot, Nat is subscribed to this ticket so we can talk here.

On on hand, we might have put that condition in based on some reason that has been lost in the sands of time. OTOH, I can't think of any good reason not to show a note when there is a note.

I propose:

- We remove the condition and just show the note.

- It goes into testing today on karlstaging.

- If Nat can't find any reports which are now wrong based on this change, we consider it a done deal.

Nat, you available for tire-kicking on karlstaging today? We have a bunch of stuff we plan to put into production tomorrow.

--Paul

On Aug 15, 2012, at 1:08 AM, Carlos de la Guardia wrote:

> The problem is that on the gsa to karl xslt stylesheet, there is a
> condition that the description for the category will only be generated
> if either the url, the phone or the fax are set. Since in the sample
> above they are not, the field is empty.
>
> Should I remove the condition? A copy of the xml file in question
> would be handy for testing.
>
> While this is done and tested, I can very easily add the note to the
> "Office of the Chairman" report. I did that here:
>
> https://karlstaging.gocept.com/people/osi/c1/r2/office-of-the-chairman
> /
>
> Let me know if I should do the same on prod in the morning.
>
> ** Changed in: karl3
> Status: New => In Progress
>
> --
> You received this bug notification because you are subscribed to the
> bug report.
> https://bugs.launchpad.net/bugs/1036853
>
> Title:
> Get the note displayed in a People report for departments
>
> Status in KARL3:
> In Progress
>
> Bug description:
> A minor request from the new OSF President, thus urgent. :)
>
> In the PEOPLE reports, we display a "note" above the grid and below
> the address information, if that category has a "note" value. This
> note value comes from GSA.
>
> This works for offices but isn't working for departments. Here is a
> note that Nat added, for the relevant category, as it is sent to us in
> GSA XML:
>
> <category id="departments"
> title="Departments"><category_item><id>1257</id><title>Office of the
> Chairman</title><hcard><fn>Office of the Chairman</fn><org>Office of
> the Chairman</org><url/><note>If you are calling from the New York
> office, dial # then the extension.</note>
>
> Can we store that and get it displayed in the report for the "Office
> of the Chairman" department?
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/1036853/+subscriptions

--
You received this bug notification because you are subscribed to the bug report.
https://bugs.launchpad.net/bugs/1036853

Title:
  Get the note disp...

[Nat Katin-Borland (nborland)]

I just looked on Staging and the note looks good, but not the address info. Is it possible to just show the note and not the address info? The office of the chairman is located in our main office, they have their own HQ.

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Paul Everitt
Sent: Wednesday, August 15, 2012 7:47 AM
To: Nathaniel Katin-Borland
Subject: Re: [Bug 1036853] Get the note displayed in a People report for departments

I forgot, Nat is subscribed to this ticket so we can talk here.

On on hand, we might have put that condition in based on some reason that has been lost in the sands of time. OTOH, I can't think of any good reason not to show a note when there is a note.

I propose:

- We remove the condition and just show the note.

- It goes into testing today on karlstaging.

- If Nat can't find any reports which are now wrong based on this change, we consider it a done deal.

Nat, you available for tire-kicking on karlstaging today? We have a bunch of stuff we plan to put into production tomorrow.

--Paul

On Aug 15, 2012, at 1:08 AM, Carlos de la Guardia wrote:

> The problem is that on the gsa to karl xslt stylesheet, there is a
> condition that the description for the category will only be generated
> if either the url, the phone or the fax are set. Since in the sample
> above they are not, the field is empty.
>
> Should I remove the condition? A copy of the xml file in question
> would be handy for testing.
>
> While this is done and tested, I can very easily add the note to the
> "Office of the Chairman" report. I did that here:
>
> https://karlstaging.gocept.com/people/osi/c1/r2/office-of-the-chairman
> /
>
> Let me know if I should do the same on prod in the morning.
>
> ** Changed in: karl3
> Status: New => In Progress
>
> --
> You received this bug notification because you are subscribed to the
> bug report.
> https://bugs.launchpad.net/bugs/1036853
>
> Title:
> Get the note displayed in a People report for departments
>
> Status in KARL3:
> In Progress
>
> Bug description:
> A minor request from the new OSF President, thus urgent. :)
>
> In the PEOPLE reports, we display a "note" above the grid and below
> the address information, if that category has a "note" value. This
> note value comes from GSA.
>
> This works for offices but isn't working for departments. Here is a
> note that Nat added, for the relevant category, as it is sent to us in
> GSA XML:
>
> <category id="departments"
> title="Departments"><category_item><id>1257</id><title>Office of the
> Chairman</title><hcard><fn>Office of the Chairman</fn><org>Office of
> the Chairman</org><url/><note>If you are calling from the New York
> office, dial # then the extension.</note>
>
> Can we store that and get it displayed in the report for the "Office
> of the Chairman" department?
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/karl3/+bug/1036853/+subscriptions

--
You received this bug notification because you are subscribed to the bug report.
https...

[Paul Everitt (paul-agendaless)]

Nat took Carlos's advice and put in a phone number, all works fine.

[Paul Everitt (paul-agendaless)]

If you want address info hidden in some places, then yes that's a software change and we need to re-open this.

I had thought you were putting in just the phone number, which be enough. And since the Note is about the phone number, it makes sense. :)

--Pau

On Aug 15, 2012, at 9:53 AM, Nat Katin-Borland wrote:

> I just looked on Staging and the note looks good, but not the address
> info. Is it possible to just show the note and not the address info?
> The office of the chairman is located in our main office, they have
> their own HQ.
>
> -----Original Message-----
> From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Paul Everitt
> Sent: Wednesday, August 15, 2012 7:47 AM
> To: Nathaniel Katin-Borland
> Subject: Re: [Bug 1036853] Get the note displayed in a People report for departments
>
> I forgot, Nat is subscribed to this ticket so we can talk here.
>
> On on hand, we might have put that condition in based on some reason
> that has been lost in the sands of time. OTOH, I can't think of any good
> reason not to show a note when there is a note.
>
> I propose:
>
> - We remove the condition and just show the note.
>
> - It goes into testing today on karlstaging.
>
> - If Nat can't find any reports which are now wrong based on this
> change, we consider it a done deal.
>
> Nat, you available for tire-kicking on karlstaging today? We have a
> bunch of stuff we plan to put into production tomorrow.
>
> --Paul
>
> On Aug 15, 2012, at 1:08 AM, Carlos de la Guardia wrote:
>
>> The problem is that on the gsa to karl xslt stylesheet, there is a
>> condition that the description for the category will only be generated
>> if either the url, the phone or the fax are set. Since in the sample
>> above they are not, the field is empty.
>>
>> Should I remove the condition? A copy of the xml file in question
>> would be handy for testing.
>>
>> While this is done and tested, I can very easily add the note to the
>> "Office of the Chairman" report. I did that here:
>>
>> https://karlstaging.gocept.com/people/osi/c1/r2/office-of-the-chairman
>> /
>>
>> Let me know if I should do the same on prod in the morning.
>>
>> ** Changed in: karl3
>> Status: New => In Progress
>>
>> --
>> You received this bug notification because you are subscribed to the
>> bug report.
>> https://bugs.launchpad.net/bugs/1036853
>>
>> Title:
>> Get the note displayed in a People report for departments
>>
>> Status in KARL3:
>> In Progress
>>
>> Bug description:
>> A minor request from the new OSF President, thus urgent. :)
>>
>> In the PEOPLE reports, we display a "note" above the grid and below
>> the address information, if that category has a "note" value. This
>> note value comes from GSA.
>>
>> This works for offices but isn't working for departments. Here is a
>> note that Nat added, for the relevant category, as it is sent to us in
>> GSA XML:
>>
>> <category id="departments"
>> title="Departments"><category_item><id>1257</id><title>Office of the
>> Chairman</title><hcard><fn>Office of the Chairman</fn><org>Office of
>> the Chairman</org><url/><note>If you are calling from the New York
>> office, dial # th...

[Nat Katin-Borland (nborland)]

I think we're all set with this now!

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Paul Everitt
Sent: Wednesday, August 15, 2012 10:36 AM
To: Nathaniel Katin-Borland
Subject: Re: [Bug 1036853] Get the note displayed in a People report for departments

If you want address info hidden in some places, then yes that's a software change and we need to re-open this.

I had thought you were putting in just the phone number, which be enough. And since the Note is about the phone number, it makes sense. :)

--Pau

On Aug 15, 2012, at 9:53 AM, Nat Katin-Borland wrote:

> I just looked on Staging and the note looks good, but not the address
> info. Is it possible to just show the note and not the address info?
> The office of the chairman is located in our main office, they have
> their own HQ.
>
> -----Original Message-----
> From: <email address hidden> [mailto:<email address hidden>] On Behalf
> Of Paul Everitt
> Sent: Wednesday, August 15, 2012 7:47 AM
> To: Nathaniel Katin-Borland
> Subject: Re: [Bug 1036853] Get the note displayed in a People report
> for departments
>
> I forgot, Nat is subscribed to this ticket so we can talk here.
>
> On on hand, we might have put that condition in based on some reason
> that has been lost in the sands of time. OTOH, I can't think of any
> good reason not to show a note when there is a note.
>
> I propose:
>
> - We remove the condition and just show the note.
>
> - It goes into testing today on karlstaging.
>
> - If Nat can't find any reports which are now wrong based on this
> change, we consider it a done deal.
>
> Nat, you available for tire-kicking on karlstaging today? We have a
> bunch of stuff we plan to put into production tomorrow.
>
> --Paul
>
> On Aug 15, 2012, at 1:08 AM, Carlos de la Guardia wrote:
>
>> The problem is that on the gsa to karl xslt stylesheet, there is a
>> condition that the description for the category will only be
>> generated if either the url, the phone or the fax are set. Since in
>> the sample above they are not, the field is empty.
>>
>> Should I remove the condition? A copy of the xml file in question
>> would be handy for testing.
>>
>> While this is done and tested, I can very easily add the note to the
>> "Office of the Chairman" report. I did that here:
>>
>> https://karlstaging.gocept.com/people/osi/c1/r2/office-of-the-chairma
>> n
>> /
>>
>> Let me know if I should do the same on prod in the morning.
>>
>> ** Changed in: karl3
>> Status: New => In Progress
>>
>> --
>> You received this bug notification because you are subscribed to the
>> bug report.
>> https://bugs.launchpad.net/bugs/1036853
>>
>> Title:
>> Get the note displayed in a People report for departments
>>
>> Status in KARL3:
>> In Progress
>>
>> Bug description:
>> A minor request from the new OSF President, thus urgent. :)
>>
>> In the PEOPLE reports, we display a "note" above the grid and below
>> the address information, if that category has a "note" value. This
>> note value comes from GSA.
>>
>> This works for offices b...