task state isn't reset after image snapshot

[Dan Prince]

After creating an image snapshot I'm getting the following error when trying to do anything to the instance which I snapshotted. See the example below where 'holler' is my snapshot image (just created).

-----------------+
-bash-4.2# nova image-list
+--------------------------------------+---------+--------+--------------------------------------+
| ID | Name | Status | Server |
+--------------------------------------+---------+--------+--------------------------------------+
| 362de461-6ef9-4063-9bc9-82069bbc8eb3 | holler | ACTIVE | 2af49a10-4582-4889-8d76-c449b9bce378 |
| a849c092-94ea-4b1f-b2a2-827ebd5c1c76 | original | ACTIVE | |
+--------------------------------------+---------+--------+--------------------------------------+
-bash-4.2# nova list
+--------------------------------------+------+--------+--------------------+
| ID | Name | Status | Networks |
+--------------------------------------+------+--------+--------------------+
| 2af49a10-4582-4889-8d76-c449b9bce378 | test | ACTIVE | public=192.168.0.6 |
+--------------------------------------+------+--------+--------------------+
-bash-4.2# nova rebuild 2af49a10-4582-4889-8d76-c449b9bce378 362de461-6ef9-4063-9bc9-82069bbc8eb3
ERROR: Cannot 'rebuild' while instance is in task_state image_snapshot (HTTP 409) (Request-ID: req-768aaeff-1fc4-4824-99eb-d0f286e6f581)

[Dan Prince (dan-prince)]

Looks like the recent reverts_task_state decorator commit is the problem d8d7100f8c10ecd388d1943bee9298a913a6990a.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/11372

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/11372
Committed: http://github.com/openstack/nova/commit/0eb53c035ab290c9574c1388bde59f7d05f64efc
Submitter: Jenkins
Branch: master

commit 0eb53c035ab290c9574c1388bde59f7d05f64efc
Author: Dan Prince <email address hidden>
Date: Tue Aug 14 17:12:13 2012 -0400

    Set task_state=None when finished snapshotting.

    Reverts part of recent reverts_task_state commit
    d8d7100f8c10ecd388d1943bee9298a913a6990a which removed
    code that resets the task_state to None once a snapshot has
    been completed.

    Fixes LP Bug #1036835.

    Change-Id: I7d30d16ca110f022b0d1f6b2fb05ba3aa52fa4d1