missing _cache_image() in libvirt driver

Bug #1036419 reported by Yun Mao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Michael Still

Bug Description

pre_block_migration() might call self._cache_image, which is refactored away from the driver since change I0d01cb7d2fd67de2565b8d45d34f7846ad4112c2

Changed in nova:
status: New → Confirmed
importance: Undecided → High
Michael Still (mikal)
Changed in nova:
assignee: nobody → Michael Still (mikalstill)
Revision history for this message
Michael Still (mikal) wrote :

This wasn't picked up (among other reasons) because the test coverage for this method is poor -- none of the else block after "if not info['backing_file'] has tests, not the kernel and ram disk fetch.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11395

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/11395
Committed: http://github.com/openstack/nova/commit/5738e6a470eaec9389a15689cf5be8ac9e2115ac
Submitter: Jenkins
Branch: master

commit 5738e6a470eaec9389a15689cf5be8ac9e2115ac
Author: Michael Still <email address hidden>
Date: Wed Aug 15 17:57:14 2012 +1000

    Port pre_block_migration to new image caching

    This resolves bug 1036419, which was a missed call to _cache_image
    when that method was refactored away.

    Change-Id: I68f6aced5382e378dc707fd003d27dbfdd24aded

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.