python-quantuclient needs pyparsing

[dan wendlandt]

it seems like cliff should have this as a depedency, but it does not, so we should add it to pip-requires.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/11251

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/11251
Committed: http://github.com/openstack/python-quantumclient/commit/466e704bfecb3b0797c2c0554b68d671f35a35e1
Submitter: Jenkins
Branch: master

commit 466e704bfecb3b0797c2c0554b68d671f35a35e1
Author: Dan Wendlandt <email address hidden>
Date: Sun Aug 12 13:39:22 2012 -0700

    add pyparsing to pip-requires

    bug 1035953

    Change-Id: Ie18fa78f242920e1acfdf1af15232591908c8de8

[Akihiro Motoki (amotoki)]

Hi Dan,

Are you using Ubuntu 12.04?

Exactly speaking, this is a bug on python-cmd2 package on ubuntu.
cmd2 requires pyparsing but python-cmd2 package does not declare python-pyparsing dependency.
I filed a bug about: this https://bugs.launchpad.net/devstack/+bug/1032243 (and will post a patch to gerrit).

I prefer to add python-pyparsing to devstack/files/apts/general
rathen than to add pyparsing to quantumclient/tools/pip-requires.

cmd2 provided on pypi has this problem. If I install cmd2 via pip, pyparsing is automatically installed
according to its dependency rule.

But now there is a little time for F-3 and the above commit has no side effect, we can leave it unchanged.

Thanks,

[dan wendlandt (danwent)]

Yes, this is on 12.04 . Ok, we can unwind this if we like, but I agree that there's little harm. Is this bug already fixed upstream for 12.10?

[Akihiro Motoki (amotoki)]

I checked the package status of Ubuntu.
This bug does not seem to be fixed (according to launchpad package information on 12.10).

I filed a bug report on it. https://bugs.launchpad.net/ubuntu/+source/cmd2/+bug/1036295
I hope it will be fixed on 12.04 (precise) and 12.10 (quantal).

[Akihiro Motoki (amotoki)]

Although pyparsing was added to pip-requires, pyparsing is not installed in devstack.
Since setup.py in quantumclient does not specify "install_requires" as setuptools.setup(),
pip-requires is not taken into account by setup.py.

[Akihiro Motoki (amotoki)]

I reported a bug in the previous comment as another bug in quantumclient.
https://bugs.launchpad.net/python-quantumclient/+bug/1038587.