Horizon shouldn't manually raise third-party library exceptions

Bug #1035511 reported by Brian Waldon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Gabriel Hurley

Bug Description

Horizon is currently raising [keystone|glance|nova]client exceptions in horizon/tests/test_data/exceptions.py. That's bad practice as you aren't guaranteed the interface to raising those exceptions won't change. If that codepath needs to be tested, Horizon should use mock objects.

Changed in horizon:
assignee: nobody → Gabriel Hurley (gabriel-hurley)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/11196
Committed: http://github.com/openstack/horizon/commit/caf166eacba9bb4f47fc668a8ea74688cd4e4b5e
Submitter: Jenkins
Branch: master

commit caf166eacba9bb4f47fc668a8ea74688cd4e4b5e
Author: Gabriel Hurley <email address hidden>
Date: Sat Aug 11 16:33:56 2012 -0700

    Update python-glanceclient to allow anything < v2

    The python-glanceclient pythonic API shouldn't break until v2 is
    released, so let's allow anything up to that known point.

    Alters the way test exceptions are constructed so that we're
    not dependent on the internals of how 3rd party libraries
    handle their exceptions while still being able to use them
    for real testing in Horizon.

    Fixes bug 1035511

    Change-Id: I9a4379a19d5d6dee9d2349a73d9321def45ad78d

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.