min_count and max_count not validated

Bug #1035482 reported by Ed Bak
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Ed Bak

Bug Description

In Folsom, min_count and max_count are not validated to be numeric values and > 0 in nova/api/openstack/compute/servers.py causing an HTTPInternalServerError to be thrown. Checks need to be added and an HTTPBadRequest should be thrown with a more descriptive error message.

Ed Bak (ed-bak2)
Changed in nova:
assignee: nobody → Ed Bak (ed-bak2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11188

Changed in nova:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/11188
Committed: http://github.com/openstack/nova/commit/710909b57f1a365f156f07a281712fac8da6de7e
Submitter: Jenkins
Branch: master

commit 710909b57f1a365f156f07a281712fac8da6de7e
Author: Ed Bak <email address hidden>
Date: Fri Aug 10 22:00:55 2012 +0000

    Validate that min_count & max_count parameters are numeric.

    Changed nova/api/openstack/compute/servers.py to include
    validation of min_count and max_count. min_count and max_count
    must be numeric values >=1 and min_count must be <= max_count.
    Also, added tests to test_servers.py to verify these restrictions.

    Fixes: bug #1035482
    Change-Id: I530c11b683a905ee67f679ef485c9f7669f1e074

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.