ssh commands error return codes ignored

[Javier Collado]

When running test cases from the server using run_utah_tests.py, I see that the errors for the commands executed in the VM through SSH are ignored.

For example, after a utah-client package installation failure, the utah binary isn't found:
2012-08-10 10:41:50,233 utah-24-quantal-amd64 INFO: Running command through SSH: utah -r /tmp/master.run -o /var/log/utah/utah-24-quantal-amd64_master.run_tmp
2012-08-10 10:41:50,236 utah-24-quantal-amd64 DEBUG: Closing SSH connection
2012-08-10 10:41:50,237 utah-24-quantal-amd64 DEBUG: Standard output follows:
2012-08-10 10:41:50,237 utah-24-quantal-amd64 DEBUG: Standard error follows:
2012-08-10 10:41:50,237 utah-24-quantal-amd64 DEBUG: bash: utah: command not found

Running this command directly in the VM returns 127, but the server ignores that and still tries to get results file from the VM as if the client execution was successful.

[Javier Collado (javier.collado)]

In this case it seems that SSHMixin.run is properly returning the code, but it's being ignored by the caller here:
machine.run('utah' + extraopts + options, root=True)

I'm going to add a check and raise an exception if the code isn't successful.

[Javier Collado (javier.collado)]

I haven't seen any other command for which a return code check should be needed, so I'll check just utah-client output for now.

[Javier Collado (javier.collado)]

Code is ready but it depends on the changes for bug1035198, so I'll wait until it's merged to test it properly.