xenapi: race condition between creating instance and fetching console URL working

[Johannes Erdfelt]

There is a lag between when an instance is created and when the os-getVNCConsole action actually works. In between those two times, a misleading 404 error will be returned.

This is because the VM object isn't created in the dom0 until part way through the build phase.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/10989

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/10989
Committed: http://github.com/openstack/nova/commit/26b1523eba3805a497c23e3b6707a85670ee11be
Submitter: Jenkins
Branch: master

commit 26b1523eba3805a497c23e3b6707a85670ee11be
Author: Johannes Erdfelt <email address hidden>
Date: Tue Aug 7 19:53:24 2012 +0000

    Return 409 error if get_vnc_console is called before VM is created

    Fixes bug 1034117

    In the xenapi driver, the URL returned for a VNC console will include
    information to locate the particular VM on the dom0, however the VM isn't
    create until part way through the build process. This leaves a window
    where a 404 error could be returned by the os-getVNCConsole action.
    Change this to return a 409 meaning it's not ready yet.

    Change-Id: Icc3b288d1aae12eb264b2be7fc8f9465d568af74