test_db_plugin does not test other plugins
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Fix Released
|
Undecided
|
Salvatore Orlando |
Bug Description
In Quantum v1, we used to have a set of unit tests which could be executed against several plugins by changing the PLUGIN_DIR environment variable. (note: this is still unit testing, with the only difference that the test does not cover the code 'base' or 'fake' plugin, but some other plugin).
With Quantum v2, we have now test_api_v2, which is meant to do api-layer testing, and indeed mocks the plugin, and test_db_plugin, which is meant to verify the behaviour of the plugin. Howerver, test_db_plugin_v2 only tests QuantumDbPluginV2, regardless of the PLUGIN_DIR setting.
It might be argued that this is intended behaviour, but since most if not all plugins extend the DB plugin, the same tests could be reused. It would be a shame to ask plugin providers to reimplement the same unit tests. It might then be worth finding a way for making the plugin configurable.
Please note: as we probably did not notice this (I was personally assuming PLUGIN_DIR still worked with v2), the Ryu plugin seems to be broken - as it appears to be at least a syntax error for a missing import.
Changed in quantum: | |
assignee: | nobody → Salvatore Orlando (salvatore-orlando) |
milestone: | none → folsom-3 |
Changed in quantum: | |
status: | Fix Committed → Fix Released |
Changed in quantum: | |
milestone: | folsom-3 → 2012.2 |
Fix proposed to branch: master /review. openstack. org/10643
Review: https:/