rpc review: create_consumer() has bogus conf argument in base class

Bug #1031713 reported by Mark McLoughlin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-common
Fix Released
Medium
Mark McLoughlin

Bug Description

Base class definition is:

  class Connection(object):
      def create_consumer(self, conf, topic, proxy, fanout=False):

but all implementations have:

  class Connection(object):
      def create_consumer(self, topic, proxy, fanout=False):

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/10652

Changed in openstack-common:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-common (master)

Reviewed: https://review.openstack.org/10652
Committed: http://github.com/openstack/openstack-common/commit/8557af7bc0a12b6981b18c71915434562cd1431f
Submitter: Jenkins
Branch: master

commit 8557af7bc0a12b6981b18c71915434562cd1431f
Author: Mark McLoughlin <email address hidden>
Date: Wed Aug 1 15:12:52 2012 +0100

    Remove bogus conf argument from create_consumer()

    Fixes bug #1031713

    Commit 0b11668 in nova added a conf parameter to the create_consumer()
    method in the base class, but not to the implementations. Looks to
    be a random thinko.

    Change-Id: I92b87eed2f7708af696e02e229bf6daa0d305fdd

Changed in openstack-common:
status: In Progress → Fix Committed
Mark McLoughlin (markmc)
Changed in openstack-common:
milestone: folsom-3 → 2012.2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.