OpenStack Compute (nova)

Compute logs full of auto-resize-confirm for instances in task_state "deleting"

Bug #1030175 reported by Kevin L. Mitchell on 2012-07-27

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Undecided	Kevin L. Mitchell	OpenStack Compute (nova) 2012.2 "folsom"

Bug Description

Logs for compute are full of messages like the below:

    2012-07-27 19:17:41 INFO nova.compute.manager [-] Found 22 unconfirmed migrations older than 86400 seconds
    2012-07-27 19:17:41 INFO nova.compute.manager [-] Automatically confirming migration 16438 for instance 9a0eb239-6c9a-4fb4-8b86-a4f7ebc03cf5
    2012-07-27 19:17:41 ERROR nova.compute.manager [-] [instance: 9a0eb239-6c9a-4fb4-8b86-a4f7ebc03cf5] Error auto-confirming resize: Instance 9a0eb239-6c9a-4fb4-8b86-a4f7ebc03cf5 in task_state deleting. Cannot confirm_resize while the instance is in this state.. Will retry later.
    2012-07-27 19:17:41 INFO nova.compute.manager [-] Automatically confirming migration 16541 for instance 62673b3c-dfe6-481e-a1fe-bff350c31b6a
    2012-07-27 19:17:41 ERROR nova.compute.manager [-] [instance: 62673b3c-dfe6-481e-a1fe-bff350c31b6a] Error auto-confirming resize: Instance 62673b3c-dfe6-481e-a1fe-bff350c31b6a in task_state deleting. Cannot confirm_resize while the instance is in this state.. Will retry later.
    …

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-07-27: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/10442

Changed in nova:
assignee:	nobody → Kevin L. Mitchell (klmitch)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2012-07-28: Fix merged to nova (master)

Reviewed: https://review.openstack.org/10442
Committed: http://github.com/openstack/nova/commit/2740ef8f31a98a9b1486af344ef8cb3399e68aa0
Submitter: Jenkins
Branch: master

commit 2740ef8f31a98a9b1486af344ef8cb3399e68aa0
Author: Kevin L. Mitchell <email address hidden>
Date: Fri Jul 27 18:49:05 2012 -0500

Fix state logic for auto-confirm resizes

    In the compute manager, the _poll_unconfirmed_resizes() periodic
    task mishandled state checks, and would call confirm_resize() in
    invalid states. This patch fixes the logic so that confirm_resize()
    is only called if the instance is in vm_state 'resized' and
    task_state None. The unit test is also fixed for the proper logic.

Fixes bug 1030175.

Change-Id: I66028b7042d88fb0f1f41df07f42b4b02cf60247