booting instances under xenserver fails with Xb.Invalid

Bug #1029773 reported by Chris Behrens
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
High
Chris Behrens

Bug Description

xenapi returns a Xb.Invalid failure for VM.start when metadata keys contain characters other than the following:

ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-/_@

This is due to a recent addition where we're storing instance metadata in xenstore. Xenstore only allows the above characters in keys.

Writing the data to the VM's param list is OK.. but the VM.start will fail.

Chris Behrens (cbehrens)
Changed in nova:
importance: Undecided → High
status: New → Triaged
Chris Behrens (cbehrens)
Changed in nova:
assignee: nobody → Chris Behrens (cbehrens)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/10395

Chris Behrens (cbehrens)
summary: - booting instances under xenserver fail with Xb.Invalid
+ booting instances under xenserver fails with Xb.Invalid
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/10395
Committed: http://github.com/openstack/nova/commit/6bff9a5f4455cff14aa9c7c1fbf8e9fe36d203aa
Submitter: Jenkins
Branch: master

commit 6bff9a5f4455cff14aa9c7c1fbf8e9fe36d203aa
Author: Chris Behrens <email address hidden>
Date: Fri Jul 27 07:04:58 2012 +0000

    Sanitize xenstore keys for metadata injection

    Xenstore only allows certain characters in key names. Change disallowed
    characters as well as '/' to '_'.

    Fixes bug 1029773

    Change-Id: I04055bfbe662f3f3e9d90336d03670aa5468e780

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.