AttributeError: 'module' object has no attribute 'check_output' running hacking.py

Bug #1029014 reported by Kevin L. Mitchell
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Critical
Chris Behrens

Bug Description

Running "tox -e pep8" now reports the following:

    Traceback (most recent call last):
      File "tools/hacking.py", line 408, in <module>
        once_git_check_commit_title()
      File "tools/hacking.py", line 389, in once_git_check_commit_title
        title = subprocess.check_output('git log --pretty=%s -1', shell=True)
    AttributeError: 'module' object has no attribute 'check_output'

This will be an issue on systems running Python 2.6 only, which is why it didn't interfere with gate checks; subprocess from Python 2.7 does have the check_output() function.

Chris Behrens (cbehrens)
Changed in nova:
assignee: nobody → Chris Behrens (cbehrens)
importance: Undecided → Critical
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/10331

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/10331
Committed: http://github.com/openstack/nova/commit/e6f2e886a4246098eefae9d9a564b321b28280c2
Submitter: Jenkins
Branch: master

commit e6f2e886a4246098eefae9d9a564b321b28280c2
Author: Chris Behrens <email address hidden>
Date: Thu Jul 26 09:15:09 2012 +0000

    Replace subprocess.check_output with Popen

    The check_output method does not exist in python 2.6

    Fixes bug 1029014

    Change-Id: I1ee24fa2029f21706924cc19dfcbc41655b022e6

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.