leaks from valgrind analysis

[Daniel Schürmann]

attached a patch sealing some leaks detected by valgrind in 1.11

[RJ Skerry-Ryan (rryan)]

thanks daniel -- looks good to me
On Sat, Jul 21, 2012 at 6:56 PM, Daniel Schürmann <
<email address hidden>> wrote:

> ** Patch added: "leak.patch"
>
> https://bugs.launchpad.net/bugs/1027515/+attachment/3231441/+files/leak.patch
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1027515
>
> Title:
> leaks from valgrind analysis
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1027515/+subscriptions
>

[Daniel Schürmann (daschuer)]

commited to lp:mixxx/1.11 #3323

[Owen Williams (ywwg)]

I'm getting crashes, I think because of this patch. Log attached.

[Daniel Schürmann (daschuer)]

I don't get the point why the patch causes the crash, maybe its a timing issue.

But anyhow .. The attached patch solves a race condition when a thread tries to write to the logfile when it is about to be close by main.

I cannot reproduce the crash on Ubuntu Lucid. Was this actually tested with lp:mixxx/1.11?
I have no such a message in my log: "QThread: Destroyed while thread is still running"

It seams there is an additional bug on the destructor procedure of EngineWorkerScheduler.

Any clue which tread is still running?

[Owen Williams (ywwg)]

I'll debug this more and see if I can figure it out.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6586