icons now constrained in height (but not width)

[Steve Graham]

I upgraded cairo-dock on Debian Unstable (AMD64) from 2.4.0 to 3.0.0-2

A minor display problem is that I had icons on the main dock which previously were larger than the default size. For example, the default icon size is 48x48, but clock applet was configured to display an icon of 64x64 pixels.

Under 3.0.0-2 the clock is rendered as an oval of size 64x48. (i.e. the desired height is ignored, but the width setting is applied).

I run cairo-dock on opengl rendering, with openbox and xcompmgr. No session management etc.

[Matthieu Baerts (matttbe)]

Hello and thank you for this bug report!

Yes, I confirm that we forgot to fix this bug :-/
But it should be fixed now on BZR (rev 1132 [¹])!

Feel free to test this new modification and to confirm if it's fixed or not (you'll have to compile the dock by yourself but there is a script if you want to quickly test: http://glx-dock.org/ww_page.php?p=From%20BZR&lang=en#3-Debian%20/%20Ubuntu ;) ).

Regards,

Matt

[¹] https://bazaar.launchpad.net/~cairo-dock-team/cairo-dock-core/cairo-dock/revision/1132

PS: I'm just a bit curious about the use of non square icons, may you share a screenshot of your dock? :)

[Steve Graham (7-launchpad-annaghvarn-plus-com)]

I will give the BZR version a try.

I think you might have misunderstood my post slightly: I do not normally have non-square icons on the dock. My clock icon was equal in height and width until the upgrade, but bigger than the other icons. After the upgrade, it became oval -- width was retained but height was constrained.

(However, with the bug, my switcher icon on the dock now also has non-square proportions, but I like that! It shows widescreen desktops more similar in shape to the full-size screens.)

I'll attach a couple of screenshots. They're from different machines, one upgraded and one not. The docks aren't set up identically, but I hope it will show the difference.

[Matthieu Baerts (matttbe)]

You're right, I have misunderstood your problem, sorry!

I confirm this "problem" but I *think* it's a new restriction to avoid other bugs.

*@ fabounet*: can you confirm that it's not a bug?

[Steve Graham (7-launchpad-annaghvarn-plus-com)]

BZR 1132 has the same issue.

If users can NOT adjust the icon size of individual icons, why have a configuration option per icon which suggests that you can do so?

In my opinion, users should be able to independently set the height and width of all items on the dock. This worked perfectly on previous versions.

[Steve Graham (7-launchpad-annaghvarn-plus-com)]

(I realize now that you can independently change the size of an applet, but not the other dock items. That would be an enhancement.)

[Matthieu Baerts (matttbe)]

In fact, currently you can adjust the icon size of all applets but the height can't be higher than the height of the icons' dock.

If you want to have an icon with an higher height, the dock's window has to be increased too (in order to have enough place to display the labels) but labels have to be moved to not be over the icon. It's mainly because there are other consequences which made the code more complex (and can cause more bugs) just for this feature and I guess this is why fabounet has removed this feature (but it's maybe better to wait for his answer ;) ).
Note that you can also place this clock applet in a desklet mode with the size that you want to have ;)

[John Baboval (baboval-launchpad)]

I know this is a little old now... I came upon this because I was experiencing the same problem. The 64x64 clock became 64x48 when updating to the new version.

I wanted to add a comment because you said you were curious about the use of non-square icons. XenClient Enterprise ships with Cairo-dock, and uses non-square icons as thumbnails of VM screens. If the system has a 16:9 display, the dock will contain a 16:9 icon for each running guest.

[Matthieu Baerts (matttbe)]

Hello,

> XenClient Enterprise ships with Cairo-dock, and uses non-square icons as thumbnails of VM screens. If the system has a 16:9 display, the dock will contain a 16:9 icon for each running guest.

Yes but it's not a problem because the icon is wider than high :)
This is how it looks like with Gimp when editing a screenshot (16:10)
  http://uppix.net/0/e/c/75dca0279cb37caca6ab7f2f07f11.png

(Note that it's also possible to use icons sizes that are wider than high and you can also specify a custom size for each launcher)

[Fabounet (fabounet03)]

well, in this case the icon is actually still squared :-)
But another case is for instance the Clock in numeric mode (if you
display the seconds or the date, it's better to enlarge the icon), or
the Switcher (in a panel, it's better to display your desktops side by
side, in a wide icon).

However, the icons are always constrained by the default height. I
understand that the icon suddenly becoming non-square might shock at
first though ^_^

2012/11/6 Matthieu Baerts <email address hidden>:
> Hello,
>
>> XenClient Enterprise ships with Cairo-dock, and uses non-square icons
> as thumbnails of VM screens. If the system has a 16:9 display, the dock
> will contain a 16:9 icon for each running guest.
>
> Yes but it's not a problem because the icon is wider than high :)
> This is how it looks like with Gimp when editing a screenshot (16:10)
> http://uppix.net/0/e/c/75dca0279cb37caca6ab7f2f07f11.png
>
> (Note that it's also possible to use icons sizes that are wider than
> high and you can also specify a custom size for each launcher)
>
> --
> You received this bug notification because you are a member of Cairo-
> Dock Team, which is subscribed to Cairo-Dock Core.
> https://bugs.launchpad.net/bugs/1025706
>
> Title:
> icons now constrained in height (but not width)
>
> Status in Cairo-Dock : Core:
> Fix Committed
>
> Bug description:
> I upgraded cairo-dock on Debian Unstable (AMD64) from 2.4.0 to 3.0.0-2
>
> A minor display problem is that I had icons on the main dock which
> previously were larger than the default size. For example, the default
> icon size is 48x48, but clock applet was configured to display an icon
> of 64x64 pixels.
>
> Under 3.0.0-2 the clock is rendered as an oval of size 64x48. (i.e.
> the desired height is ignored, but the width setting is applied).
>
> I run cairo-dock on opengl rendering, with openbox and xcompmgr. No
> session management etc.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/cairo-dock-core/+bug/1025706/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cairo-dock-team
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~cairo-dock-team
> More help : https://help.launchpad.net/ListHelp

[Matthieu Baerts (matttbe)]

@fabounet: should we mark this bug as 'Wont' fix'?

[Fabounet (fabounet03)]

Well, for me, icons can be larger than wide (useful for the Text theme for
instance, and also useful for applets that contain several elements like
Switcher, or some text like Clock)
but they all have the same height: this makes it coherent

before, an icon could be higher, but then the whole dock would be the high
of the larger icon, and I'm not a fan of this solution :-)
I think that with desklets and multiple docks, we can make almost any theme
we want, so I'm ok with the current situation.

2013/10/4 Matthieu Baerts <email address hidden>

> @fabounet: should we mark this bug as 'Wont' fix'?
>
> --
> You received this bug notification because you are a member of Cairo-
> Dock Devs, which is subscribed to Cairo-Dock Core.
> https://bugs.launchpad.net/bugs/1025706
>
> Title:
> icons now constrained in height (but not width)
>
> Status in Cairo-Dock : Core:
> Fix Committed
>
> Bug description:
> I upgraded cairo-dock on Debian Unstable (AMD64) from 2.4.0 to 3.0.0-2
>
> A minor display problem is that I had icons on the main dock which
> previously were larger than the default size. For example, the default
> icon size is 48x48, but clock applet was configured to display an icon
> of 64x64 pixels.
>
> Under 3.0.0-2 the clock is rendered as an oval of size 64x48. (i.e.
> the desired height is ignored, but the width setting is applied).
>
> I run cairo-dock on opengl rendering, with openbox and xcompmgr. No
> session management etc.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/cairo-dock-core/+bug/1025706/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cairo-dock-team
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~cairo-dock-team
> More help : https://help.launchpad.net/ListHelp
>

[Steve Graham (7-launchpad-annaghvarn-plus-com)]

"Won't Fix" is rather sad. The distinguishing feature of Cairo-Dock is the appearance and suite of visual effects, and this is a basic bug in the visuals.

I would suggest that if you're leaving the bug in, you'll have to fix the user preferences GUI to make the more limited functionality clear to users.

[Fabounet (fabounet03)]

I agree with the 2nd part :-)

2013/10/9 Steve Graham <email address hidden>

> "Won't Fix" is rather sad. The distinguishing feature of Cairo-Dock is
> the appearance and suite of visual effects, and this is a basic bug in
> the visuals.
>
> I would suggest that if you're leaving the bug in, you'll have to fix
> the user preferences GUI to make the more limited functionality clear to
> users.
>
> --
> You received this bug notification because you are a member of Cairo-
> Dock Devs, which is subscribed to Cairo-Dock Core.
> https://bugs.launchpad.net/bugs/1025706
>
> Title:
> icons now constrained in height (but not width)
>
> Status in Cairo-Dock : Core:
> Won't Fix
>
> Bug description:
> I upgraded cairo-dock on Debian Unstable (AMD64) from 2.4.0 to 3.0.0-2
>
> A minor display problem is that I had icons on the main dock which
> previously were larger than the default size. For example, the default
> icon size is 48x48, but clock applet was configured to display an icon
> of 64x64 pixels.
>
> Under 3.0.0-2 the clock is rendered as an oval of size 64x48. (i.e.
> the desired height is ignored, but the width setting is applied).
>
> I run cairo-dock on opengl rendering, with openbox and xcompmgr. No
> session management etc.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/cairo-dock-core/+bug/1025706/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cairo-dock-team
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~cairo-dock-team
> More help : https://help.launchpad.net/ListHelp
>

[Matthieu Baerts (matttbe)]

@fabounet: where can we add this information? Can you do that? :-)

[Fabounet (fabounet03)]

that's a TODO for the 3.4, we can think of it on the forum (maybe add a
blueprint)
for instance, we could make a widget dedicated to be an optional size with
3 choices: default (= size of launchers), automatic (= the applet decides,
useful for Clock or Notification Area), custom (= custom with).

2013/10/9 Matthieu Baerts <email address hidden>

> @fabounet: where can we add this information? Can you do that? :-)
>
> ** Changed in: cairo-dock-core
> Status: Won't Fix => Triaged
>
> --
> You received this bug notification because you are a member of Cairo-
> Dock Devs, which is subscribed to Cairo-Dock Core.
> https://bugs.launchpad.net/bugs/1025706
>
> Title:
> icons now constrained in height (but not width)
>
> Status in Cairo-Dock : Core:
> Triaged
>
> Bug description:
> I upgraded cairo-dock on Debian Unstable (AMD64) from 2.4.0 to 3.0.0-2
>
> A minor display problem is that I had icons on the main dock which
> previously were larger than the default size. For example, the default
> icon size is 48x48, but clock applet was configured to display an icon
> of 64x64 pixels.
>
> Under 3.0.0-2 the clock is rendered as an oval of size 64x48. (i.e.
> the desired height is ignored, but the width setting is applied).
>
> I run cairo-dock on opengl rendering, with openbox and xcompmgr. No
> session management etc.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/cairo-dock-core/+bug/1025706/+subscriptions
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cairo-dock-team
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~cairo-dock-team
> More help : https://help.launchpad.net/ListHelp
>