POSTs logged as PUTs by the proxy server
Bug #1025433 reported by
John Dickinson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Object Storage (swift) |
Fix Released
|
Undecided
|
Darrell Bishop |
Bug Description
When the proxy is configured to implement object POSTs as COPYs, the POST request is logged as a PUT.
Changed in swift: | |
assignee: | nobody → Darrell Bishop (darrellb) |
status: | New → In Progress |
Changed in swift: | |
milestone: | none → 1.7.0 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/11636 github. com/openstack/ swift/commit/ 4a2ae2b46034e80 27bee20dcfaaf38 a9ee0c5c17
Committed: http://
Submitter: Jenkins
Branch: master
commit 4a2ae2b46034e80 27bee20dcfaaf38 a9ee0c5c17
Author: Darrell Bishop <email address hidden>
Date: Sun Aug 19 17:44:43 2012 -0700
Upating proxy-server StatsD logging.
Removed many StatsD logging calls in proxy-server and added informant- style catch-all logging in the proxy-logger middleware. server. <type>. errors" server. <type>. <verb>. <status> .timing" . Also, bytes server. <type>. <verb>. <status> .xfer". The proxy-logging
swift-
Many errors previously rolled into the "proxy-
counter will now appear broken down by response code and with timing
data at: "proxy-
transferred (sum of in + out) will be at:
"proxy-
middleware can get its StatsD config from standard vars in [DEFAULT] or
from access_log_statsd_* config vars in its config section.
Similarly to Swift Informant, request methods ("verbs") are filtered valid_http_ methods" log_statsd_ valid_http_ methods is also
using the new proxy-logging config var, "log_statsd_
which defaults to GET, HEAD, POST, PUT, DELETE, and COPY. Requests with
methods not in this list use "BAD_METHOD" for <verb> in the metric name.
To avoid user error, access_
accepted.
Previously, proxy-server metrics used "Account", "Container", and
"Object" for the <type>, but these are now all lowercase.
Updated the admin guide's StatsD docs to reflect the above changes and server. <type>. handoff_ count" and server. <type>. handoff_ all_count" metrics.
also include the "proxy-
"proxy-
The proxy server now saves off the original req.method and proxy_logging
will use this if it can (both for request logging and as the "<verb>" in
the statsd timing metric). This fixes bug 1025433.
Removed some stale access_log_* related code in proxy/server.py. Also /Application distinction as it's no longer
removed the BaseApplication
necessary.
Fixed up the sample config files a bit (logging lines, mostly).
Fixed typo in SAIO development guide.
Got proxy_logging.py test coverage to 100%.
Fixed proxy_logging.py for PEP8 v1.3.2.
Enhanced test.unit. FakeLogger to track more calls to enable testing
StatsD metric calls.
Change-Id: I45d94cb76450be 96d66fcfab56359 bdfdc3a2576