notifications for deleted instances have garbage/duplicate image_meta

[Alex Meade]

This bug is related to the fix for https://bugs.launchpad.net/nova/+bug/1021430

Currently, all of the deleted metadata is shown for an instances in compute.instance.exists notifications. This means that metadata from previous rebuilds or administrative error show up, potentially causing ambiguity on things such as what image the instance came from.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/9450

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/9450
Committed: http://github.com/openstack/nova/commit/0598db0a6c66eb2b6d2e0e3f0b3b2b921ebe8621
Submitter: Jenkins
Branch: master

commit 0598db0a6c66eb2b6d2e0e3f0b3b2b921ebe8621
Author: Alex Meade <email address hidden>
Date: Fri Jul 6 13:23:55 2012 -0400

    This patch stops metadata from being deleted when an instance is deleted.

    This patch makes it so that instance metadata, system metadata, and block
    device mappings are no longer set to deleted when an instance is deleted.
    It doesn't make sense to delete them just because the instance they describe
    has been deleted.

    This patch DOES NOT MIGRATE currently deleted metadata or block
    device mappings for currently deleted instances, that means that usage
    notifications for deleted instances that were deleted before this patch will
    show image_meta as empty.

    Fixes bug 1021830

    Change-Id: I33ee402b859834e09535c7925957bee0a1d91207