dh_apparmor runs against all binary packages, adding useless entries to lxc-dev's postinst/postrm
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
lxc (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Precise |
Fix Released
|
Low
|
Stéphane Graber | ||
Quantal |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The dh_apparmor call in debian/rules isn't called using "-p <binary package>" and so adds apparmor entries to the postinst/postrm of all the binary packages, not just the one containing the profiles.
This is clearly wrong and at the very least confusing (if not a source of bugs).
[rational]
The apparmor postinst/postrm code should only be added to the package containing the profiles and not to lxc-dev.
The fix is trivial and can potentially fix bugs.
[test case]
1) apt-get install lxc-dev
2) grep apparmor /var/lib/
2) shouldn't return anything as lxc-dev doesn't have anything to do with apparmor
[regression potential]
The change has been tested on quantal and precise, the apparmor maintainer script entries are indeed limited to just the lxc binary package after that change. Should everything go wrong, the worst that can happen is a missing apparmor maintainer script entry in lxc which will prevent a reload of the profile at upgrade time, though the profile will still be applied at boot time.
Related branches
Changed in lxc (Ubuntu Quantal): | |
status: | New → Fix Released |
Changed in lxc (Ubuntu Precise): | |
status: | New → In Progress |
importance: | Undecided → Low |
assignee: | nobody → Stéphane Graber (stgraber) |
Hello Stéphane, or anyone else affected,
Accepted lxc into precise-proposed. The package will build now and be available at http:// launchpad. net/ubuntu/ +source/ lxc/0.7. 5-3ubuntu60 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification- failed. In either case, details of your testing will help us make a better decision.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance!