Mahara

Textbox upgrade inserts too many rows per query in MySQL

Bug #1018590 reported by Richard Mansfield
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Richard Mansfield
Mahara 1.5.2

Bug Description

The upgrade to convert textboxes to artefacts tries to insert 5000 rows at a time into the artefact table. This is too much data for MySQL's default max_allowed_packet setting, and should be reduced.

See https://mahara.org/interaction/forum/topic.php?id=4474#post20477

Revision history for this message
Richard Mansfield (richard-mansfield) wrote :

https://reviews.mahara.org/1373
https://reviews.mahara.org/1374

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/1374
Committed: http://gitorious.org/mahara/mahara/commit/8fd6d5d5a8d22e3e90d7c47b3caf035d9b157cbf
Submitter: Hugh Davenport (<email address hidden>)
Branch: 1.5_STABLE

commit 8fd6d5d5a8d22e3e90d7c47b3caf035d9b157cbf
Author: Richard Mansfield <email address hidden>
Date: Wed Jun 27 18:25:31 2012 +1200

    Insert fewer rows per query in MySQL textbox upgrade (bug #1018590)

    The upgrade to convert textboxes to artefacts tries to insert 5000
    rows at a time into the artefact table. This is too much data for
    MySQL's default max_allowed_packet setting. Reducing the number of
    rows inserted per query to 100 (or a bit larger, depending on
    max_allowed_packet) fixes the upgrade problem.

    See https://mahara.org/interaction/forum/topic.php?id=4474#post20477

    Change-Id: I8335323e247abb570a434cd105d4590cad103018
    Signed-off-by: Richard Mansfield <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/1373
Committed: http://gitorious.org/mahara/mahara/commit/4218ab66c079614a26031ff1d10926abdc0baae4
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 4218ab66c079614a26031ff1d10926abdc0baae4
Author: Richard Mansfield <email address hidden>
Date: Wed Jun 27 18:25:31 2012 +1200

    Insert fewer rows per query in MySQL textbox upgrade (bug #1018590)

    The upgrade to convert textboxes to artefacts tries to insert 5000
    rows at a time into the artefact table. This is too much data for
    MySQL's default max_allowed_packet setting. Reducing the number of
    rows inserted per query to 100 (or a bit larger, depending on
    max_allowed_packet) fixes the upgrade problem.

    See https://mahara.org/interaction/forum/topic.php?id=4474#post20477

    Change-Id: I8335323e247abb570a434cd105d4590cad103018
    Signed-off-by: Richard Mansfield <email address hidden>

Hugh Davenport (hugh-davenport)
Changed in mahara:
status: In Progress → Fix Committed
Melissa Draper (melissa)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.