Edit snapshot raises an error while in Queued state

[Tihomir Trifonov]

When a snapshot is being created, and still in Queued state, the 'Edit' button is enabled, and when clicked - returns an error message. So it should be either the Edit action disabled, or the error to be handled properly and a correct error message to be displayed.

[Tue Jun 26 03:57:34 2012] [error] Traceback (most recent call last):
[Tue Jun 26 03:57:34 2012] [error] File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 111, in get_response
[Tue Jun 26 03:57:34 2012] [error] response = callback(request, *callback_args, **callback_kwargs)
[Tue Jun 26 03:57:34 2012] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/decorators.py", line 40, in dec
[Tue Jun 26 03:57:34 2012] [error] return view_func(request, *args, **kwargs)
[Tue Jun 26 03:57:34 2012] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/decorators.py", line 55, in dec
[Tue Jun 26 03:57:34 2012] [error] return view_func(request, *args, **kwargs)
[Tue Jun 26 03:57:34 2012] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/decorators.py", line 40, in dec
[Tue Jun 26 03:57:34 2012] [error] return view_func(request, *args, **kwargs)
[Tue Jun 26 03:57:34 2012] [error] File "/usr/local/lib/python2.7/dist-packages/django/views/generic/base.py", line 48, in view
[Tue Jun 26 03:57:34 2012] [error] return self.dispatch(request, *args, **kwargs)
[Tue Jun 26 03:57:34 2012] [error] File "/usr/local/lib/python2.7/dist-packages/django/views/generic/base.py", line 69, in dispatch
[Tue Jun 26 03:57:34 2012] [error] return handler(request, *args, **kwargs)
[Tue Jun 26 03:57:34 2012] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/forms/views.py", line 64, in get
[Tue Jun 26 03:57:34 2012] [error] form, handled = self.maybe_handle()
[Tue Jun 26 03:57:34 2012] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/forms/views.py", line 58, in maybe_handle
[Tue Jun 26 03:57:34 2012] [error] kwargs = self.get_form_kwargs()
[Tue Jun 26 03:57:34 2012] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/forms/views.py", line 48, in get_form_kwargs
[Tue Jun 26 03:57:34 2012] [error] kwargs = {'initial': self.get_initial()}
[Tue Jun 26 03:57:34 2012] [error] File "/opt/stack/horizon/openstack_dashboard/wsgi/../../horizon/dashboards/nova/images_and_snapshots/images/views.py", line 72, in get_initial
[Tue Jun 26 03:57:34 2012] [error] 'container_format': self.object.container_format,
[Tue Jun 26 03:57:34 2012] [error] File "/usr/local/lib/python2.7/dist-packages/glanceclient/common/base.py", line 92, in __getattr__
[Tue Jun 26 03:57:34 2012] [error] return self.__getattr__(k)
[Tue Jun 26 03:57:34 2012] [error] File "/usr/local/lib/python2.7/dist-packages/glanceclient/common/base.py", line 94, in __getattr__
[Tue Jun 26 03:57:34 2012] [error] raise AttributeError(k)
[Tue Jun 26 03:57:34 2012] [error] AttributeError: container_format

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/9054

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/9054
Committed: http://github.com/openstack/horizon/commit/18e2218b3f9437ad35517d32c2c6fa1f5443537e
Submitter: Jenkins
Branch: master

commit 18e2218b3f9437ad35517d32c2c6fa1f5443537e
Author: Tihomir Trifonov <email address hidden>
Date: Wed Jun 27 16:05:50 2012 +0300

    'Edit' image disabled if image in 'Queued' state

    As the 'edit' image/snapshot form reads
    the properties of the image, and they are
    unavailable while the image is in 'queued'
    state, this row action should be hidden
    in that case.

    Fixes bug 1017867

    Change-Id: Ice3a6bc7898cf68d28ab9c27b4173e02913f1a56