jsonutils.py is incompatible with anyjson from 3.3.2 onwards

[Tim Daly Jr.]

Newer versions of the python anyjson library support an additional "filedecoder" method:

https://bitbucket.org/runeh/anyjson/changeset/93a0e869c06c

It's just like decoder except it takes a file argument instead of a string. Since nova's jsonutils.py doesn't define a filedecoder, we get a KeyError from anyjson:

  File "/home/openstack/nova/app/nova/openstack/common/jsonutils.py", line 133, in <module>
    anyjson.force_implementation(__name__)
  File "/usr/lib/python2.6/site-packages/anyjson-0.3.3-py2.6.egg/anyjson/__init__.py", line 111, in force_implementation
    implementation = _JsonImplementation(spec)
  File "/usr/lib/python2.6/site-packages/anyjson-0.3.3-py2.6.egg/anyjson/__init__.py", line 63, in __init__
    fdec = modinfo["filedecoder"]

We can simply add the new method. Since it's on the end of the list, it's compatible with older versions of anyjson. I'll submit a patch.

[Zhongyue Luo (zyluo)]

This patch should be submitted to openstack-common first and then updated to Nova.

[Tim Daly Jr. (timjr)]

Oh, thanks, didn't know about that.

[Tim Daly Jr. (timjr)]

fix up for review: https://review.openstack.org/#/c/9013/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/9857

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/9857
Committed: http://github.com/openstack/nova/commit/12e663a8b0b253970e3bccd373d3d2f3d462f6b6
Submitter: Jenkins
Branch: master

commit 12e663a8b0b253970e3bccd373d3d2f3d462f6b6
Author: Russell Bryant <email address hidden>
Date: Mon Jul 16 12:20:44 2012 -0400

    Sync jsonutils from openstack-common.

    In addition to the following changes from openstack-common, this patch
    includes some tweak to nova unit tests. timeutils.strtime() will raise
    an exception if the year in a datetime object is before 1900.

    Changes from openstack-common:

        commit ce3071437d1871f77c4d8573cbe5f4ea8c817650
        Author: Russell Bryant <email address hidden>
        Date: Mon Jul 16 10:30:25 2012 -0400

            Use strtime() in to_primitive() for datetime objs.

            This patch updates jsonutils.to_primitive() to use timeutils.strtime()
            to convert a datimetime object to a string instead of just using str().
            This ensures that we can easily convert the string back to a datetime
            using timeutils.parse_strtime().

            Required for the nova blueprint no-db-messaging.

        commit 4c9d439ef24f5afdd74aa9153aa8fc772051e6cb
        Author: Tim Daly Jr <email address hidden>
        Date: Tue Jun 26 02:48:42 2012 +0000

            Add 'filedecoder' method to the jsonutils wrapper module.

            Fixes bug #1017765

            After version 3.3.2, the anyjson library will throw a KeyError if
            filedecoder isn't present. The filedecoder is just like the decoder
            except it takes a file instead of a string, like json.load() instead
            of json.loads().

    Change-Id: Ib51f0da8641c035371e09047de9abe3cb83203e9

[Jamie Strandboge (jdstrand)]

I just hit this trying to install keystone on Ubuntu 12.10.

[Jamie Strandboge (jdstrand)]

This commit seems to fix the issue.

[Jamie Strandboge (jdstrand)]

Note that I just modified the files directly within /usr/share, and I adjusted *both* keystone and nova, so I'm guessing the upstream commit may also need to be applied to keystone?

[Jamie Strandboge (jdstrand)]

This also affects horizon.

[Jamie Strandboge (jdstrand)]

The fix works on horizon, but then it has other problems.