vm_vdi_cleaner.py cleanup_instance() fails

Bug #1017282 reported by Chris Behrens
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Chris Behrens

Bug Description

get_connection() was removed.. and now you should just instantiate the driver class.

Traceback (most recent call last):
  File "/usr/share/nova/tools/xenserver/vm_vdi_cleaner.py", line 342, in <module>
    main()
  File "/usr/share/nova/tools/xenserver/vm_vdi_cleaner.py", line 333, in main
    verbose=verbose)
  File "/usr/share/nova/tools/xenserver/vm_vdi_cleaner.py", line 300, in clean_orphaned_instances
    cleanup_instance(session, instance, vm_ref, vm_rec)
  File "/usr/share/nova/tools/xenserver/vm_vdi_cleaner.py", line 105, in cleanup_instance
    connection = xenapi_conn.get_connection(_)
AttributeError: 'module' object has no attribute 'get_connection'

Chris Behrens (cbehrens)
summary: - vm_vdi_cleaner.py clean_instance() fails
+ vm_vdi_cleaner.py cleanup_instance() fails
Changed in nova:
importance: Undecided → Medium
assignee: nobody → Chris Behrens (cbehrens)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/8914

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/8914
Committed: http://github.com/openstack/nova/commit/0622868cc54569a30e6cf427a564b79d9b3669b5
Submitter: Jenkins
Branch: master

commit 0622868cc54569a30e6cf427a564b79d9b3669b5
Author: Chris Behrens <email address hidden>
Date: Sun Jun 24 23:08:19 2012 +0000

    Refactor vm_vdi_cleaner.py connection use

    cleanup_instance() would fail because of using old get_connection().
    This refactors everything to use XenAPIDriver().

    Fixes bug 1017282

    Change-Id: I8822f322bb8f60e5992afbe1feb45c0f4fffc893

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.