varnish does not remove PID file on stop

[Jonathan Davies]

Varnish does not remove its PID file when it is stopped via its init.d script.

Test case:
1. Install varnish: $ sudo apt-get install varnish
2. $ sudo service varnish status; echo $? # Returns 0.
3. $ sudo service varnish stop; echo $? # Returns 0.
4. $ sudo service varnish status; echo $? # Returns 1.
5. $ sudo rm -v /var/run/varnishd.pid
6. $ sudo service varnish status; echo $? # Returns 4 instead of 3.

This SRU properly fixes the init.d file so that the right exit codes are sent.

[Jonathan Davies (jpds)]

Package uploaded to precise-proposed.

[Jonathan Davies (jpds)]

Patch sent to Debian bug for syncing down to Quantal.

[Scott Kitterman (kitterman)]

Needs test case/regression potential (see https://wiki.ubuntu.com/StableReleaseUpdates) before it can be accepted.

[Scott Kitterman (kitterman)]

Hello Jonathan, or anyone else affected,

Accepted varnish into precise-proposed. The package will build now and be available in a few hours. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Jonathan Davies (jpds)]

Package confirmed working as required.

[Launchpad Janitor (janitor)]

This bug was fixed in the package varnish - 3.0.2-1ubuntu0.1

---------------
varnish (3.0.2-1ubuntu0.1) precise-proposed; urgency=low

  * varnish.init:
    - Remove PID file on stop (LP: #1014793).
    - Use start-stop-daemon for status.
 -- Jonathan Davies <email address hidden> Mon, 18 Jun 2012 19:53:22 +0100

[Mattia Rizzolo (mapreri)]

fix committed together the one for the bug #1285299.

[Launchpad Janitor (janitor)]

This bug was fixed in the package varnish - 3.0.5-1ubuntu2

---------------
varnish (3.0.5-1ubuntu2) trusty; urgency=medium

  * Add missing "needs-root" test restriction.
 -- Martin Pitt <email address hidden> Mon, 24 Mar 2014 18:13:21 +0100