Shortcut to search

[Chucho Sánchez]

It would be nice to have a shortcut to take you to the searching box, Ctrl+F or Ctrl+S are the usual ones in other players. The search would be more comfortable.

[Kurt Smolderen (kurt.smolderen)]

I'm currently working on this one but would like to get some thoughts on which is the most desirable behaviour:
(1) User has to explicitly type Ctrl+F to get the searchbox activated
(2) Searchbox is activated on any (non modifier+) keystroke.

(2) is faster and perhaps even more convenient, but prone to accidental keystrokes...

[Scott Ringwelski (sgringwe)]

2 is already implemented, actually. Take a look at line 780 in LibraryWindow.vala.

It'd be nice to also add 1.

[Chucho Sánchez (chuchoschez)]

Option (2) is pretty awsome too. Most of us are used to Ctrl+F but I think it's quite easy to get used to option (2). It could be also an option in preferences (or dconf at least) to choose which method you prefer, but that depends also on design, so it's up to you guys. Great work by the way!

[Kurt Smolderen (kurt.smolderen)]

@Scott: "2 is already implemented, actually. Take a look at line 780 in LibraryWindow.vala." -> This wasn't working for me, so I tought at first this could was not executed for some reason... After some debugging, it appears on my system the num-lock key is registered as Modifier_key_3. So when num-lock is active, GdkEventKey.state equals 16 which means the searchfield won'get focus...

When numlock is off, it works as expected...

[Chucho Sánchez (chuchoschez)]

I have checked the issue with the numlock key and it was happening the same for me if it helps

[Kurt Smolderen (kurt.smolderen)]

Scott

I've a working solution for this bug report. Modifiers are detected
correctly, instant search works and CTRL + F works. The reason I did not
yet merge and push the solution, is I think a user should be able to
leave the searchfield by pressing the Escape key () if you can enter the
field by keystrokes, you should also be able to leave it by keystrokes).
Once this is finished (probably today or tomorrow), I'll submit the
proposed solution.

Regards
Kurt

On 26-06-12 05:29, Scott Ringwelski wrote:
> ** Changed in: beat-box
> Status: Confirmed => Fix Committed
>
> ** Changed in: beat-box
> Assignee: (unassigned) => Scott Ringwelski (sgringwe)
>
> ** Changed in: beat-box
> Milestone: None => 0.6
>

[Scott Ringwelski (sgringwe)]

What would happen when esc is pressed (specifically, where would they go)? What is so bad about tabbing to leave the search field?

[Kurt Smolderen (kurt.smolderen)]

What would happen when esc is pressed (specifically, where would they go)? What is so bad
=> The previous focused widget would gain focus again

What is so bad about tabbing to leave the search field?
=> If you want to 'cancel' your search, I think it's more user-friendly/ desirable to go back to the 'previous state' (i.e. right before you performed your search). Think of it as escaping from a search in your favorite text editor: you do not want one of your toolbar buttons to gain focus, instead, you want to go back to the actual editing area...

[Scott Ringwelski (sgringwe)]

Ok, sounds good. Looking forward to seeing the implementation.

On Tue, Jun 26, 2012 at 8:36 AM, Kurt Smolderen
<email address hidden>wrote:

> What would happen when esc is pressed (specifically, where would they go)?
> What is so bad
> => The previous focused widget would gain focus again
>
> What is so bad about tabbing to leave the search field?
> => If you want to 'cancel' your search, I think it's more user-friendly/
> desirable to go back to the 'previous state' (i.e. right before you
> performed your search). Think of it as escaping from a search in your
> favorite text editor: you do not want one of your toolbar buttons to gain
> focus, instead, you want to go back to the actual editing area...
>
> --
> You received this bug notification because you are a member of BeatBox
> Team, which is the registrant for BeatBox.
> https://bugs.launchpad.net/bugs/1014554
>
> Title:
> Shortcut to search
>
> Status in BeatBox Music Player:
> Fix Committed
>
> Bug description:
> It would be nice to have a shortcut to take you to the searching box,
> Ctrl+F or Ctrl+S are the usual ones in other players. The search would
> be more comfortable.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/beat-box/+bug/1014554/+subscriptions
>