Tablesorter on the DataTables Appends Extra Row When Sorting

Bug #1013472 reported by John Postlethwait
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Gabriel Hurley

Bug Description

Repro:

Go to Instances and Volumes
Create a Volume.
Let the volume spin up and become available.
Sort the table by the size column by clicking on the Size column header.

Expected:

The table sorts by the size column.

Actual:

An extra, duplicate row, representing the "creating" status row for the volume you just created, is added to the table, and it is not sorted correctly with the rest of the results.

Changed in horizon:
assignee: nobody → Nebula (nebula)
status: New → Confirmed
Devin Carlen (devcamcar)
Changed in horizon:
importance: Undecided → Low
milestone: none → folsom-3
Revision history for this message
Gabriel Hurley (gabriel-hurley) wrote :

The tablesorter plugin's data cache isn't getting updated as the row changes (and is replaced in the DOM). Just need to update the cache before/when sorting.

Changed in horizon:
importance: Low → Medium
Changed in horizon:
status: Confirmed → In Progress
assignee: Nebula (nebula) → Gabriel Hurley (gabriel-hurley)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/11367

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/11367
Committed: http://github.com/openstack/horizon/commit/dbbdaa64ec4304d1bf94329d47d1fc5c035ef9d1
Submitter: Jenkins
Branch: master

commit dbbdaa64ec4304d1bf94329d47d1fc5c035ef9d1
Author: Gabriel Hurley <email address hidden>
Date: Tue Aug 14 12:46:43 2012 -0700

    Update tablesorter cache after ajax updates.

    Fixes bug 1013472.

    Change-Id: I161c6d1daacef4c73e1e29f5860cf78f6bf92fc9

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: folsom-3 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.