gimp-plugin-registry 5.20120523 fails to build in quantal

[Micah Gersten]

gcc -Wall -g -fPIC -O2 -Wl,-z,defs -o resynthesizer resynthesizer.o engineParams.o imageFormat.o -lgimpui-2.0 -lgimpwidgets-2.0 -lgimpmodule-2.0 -lgimp-2.0 -lgimpmath-2.0 -lgimpconfig-2.0 -lgimpcolor-2.0 -lgimpbase-2.0 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lglib-2.0 libimagesynth.a -lm
libimagesynth.a(engine.o): In function `refiner':
/build/buildd/gimp-plugin-registry-5.20120523/resynthesizer/bootchk-resynthesizer-28cade5/src/refinerThreaded.h:319: undefined reference to `g_thread_init'
resynthesizer.o: In function `run':
/build/buildd/gimp-plugin-registry-5.20120523/resynthesizer/bootchk-resynthesizer-28cade5/src/resynthesizer.c:314: undefined reference to `g_thread_init'
collect2: error: ld returned 1 exit status
make[4]: *** [resynthesizer] Error 1
make[4]: Leaving directory `/build/buildd/gimp-plugin-registry-5.20120523/resynthesizer/bootchk-resynthesizer-28cade5/src'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/build/buildd/gimp-plugin-registry-5.20120523/resynthesizer/bootchk-resynthesizer-28cade5'
make[2]: *** [all] Error 2

https://launchpadlibrarian.net/106037261/buildlog_ubuntu-quantal-amd64.gimp-plugin-registry_5.20120523_FAILEDTOBUILD.txt.gz

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "Patch attached for removing 'g_thread_init' function to fix FTBFS. Testing one more time in PPA as well." of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Micah Gersten (micahg)]

First, thank you for working on this
A few changes that I was going to make for you:
run update-maintainer
revert the standards change (we don't do this on things we import from Debian)
convert changes into a quilt patch with dep-3 headers
add patch name to changelog

Unfortunately, the debdiff even as given doesn't apply cleanly to the upstream source, could you give this another go?

[otto06217 (otto-kesselgulasch)]

Hi,

you can fix this by
1. adding AC_CHECK_LIB(gthread-2.0, g_thread_init) to the appropriate configure.in or
2. adding the parameter -lgthread-2.0 to the compiler command line

Link: http://ragnermagalhaes.blogspot.de/2007/09/undefined-reference-to-gthreadinit.html

I prefered the first solution. I could successfully build gimp-plugin-registry 5.20120523 in my PPA - https://launchpad.net/~otto-kesselgulasch/+archive/gimp.

Sorry, it's just a temporary backport. I can't wait;-)

I hope I could help.

Otto

[otto06217 (otto-kesselgulasch)]

Hi,

another thought:

Do we really need libgthread-2.0 for the gimp-plugin-registry? If not, to me it's better to remove it by the patch 'g_thread_init' function to fix FTBFS or so but for now I prefer the solution I mentioned.

The question is: What is the author's intention? Are dependencies of certain code really required? IMHO as a packager I have to do anything for building the package without remove source code via patch or making workarounds.

In this special case the author's intention is: I need g_thread_init. Basta! Therefore it has to be the packagers intension to look for errors in the surrounding build system, i.e. Gnu Autotools.

OMG! What an English. Excuse me, I'm a German.

Cheers

Otto

[Micah Gersten (micahg)]

The question is whether or not it needs to be backportable to glib < 2.32.

[otto06217 (otto-kesselgulasch)]

This patch adds AC_CHECK_LIB(gthread-2.0, g_thread_init) to configure.in

http://ragnermagalhaes.blogspot.de/2007/09/undefined-reference-to-gthreadinit.html

[otto06217 (otto-kesselgulasch)]

Micah Gersten (micahg) wrote:
> The question is whether or not it needs to be backportable to glib < 2.32.

I tried this building glib = 2.32 for Oneiric. The unfortunate users were running in dependency nightmares so I stop backporting in my PPA. I had to build new Oneiric packages like lxdm, lxlauncher and xfdesktop. IMHO this is not an option.

I don't now. I think if we want gimp-2.8 and the appropriate packages too in Ubuntu series < Precise we need "standalone" packages which almost nothing have to do with the underlying Ubuntu series < Precise. They could reside in /opt/gimp-standalone per instance.

I started such work some weeks ago but I have no results yet except babl. Shame on me.

Regards

Otto

[otto06217 (otto-kesselgulasch)]

BTW: IMHO your comment has nothing to do with the FTBFS problem.

Regards

Otto

[Micah Gersten (micahg)]

Yes, it does, it determines how to fix the issue :) As it is, precise has glib 2.32, so I don't really care in Ubuntu which way we go, Debian might care if they want this backported to squeeze.

[otto06217 (otto-kesselgulasch)]

Oh Debian, oh Debian!

Without them we would not be able to function, isn't it?

However, It's just my recommendation for fixing the FTBFS issue. You're the main maintainer;-)

But the story remains the same:

Developer vs. Packager shall have no dominion;-)

Regards

Otto

[otto06217 (otto-kesselgulasch)]

BTW: On my Kubuntu 12.04 machine I had just to fix another build issue:

--- a/resynthesizer/src/autogen.sh 2012-05-23 21:57:47.000000000 +0200
+++ b/resynthesizer/src/autogen.sh 2012-06-20 21:13:51.038000297 +0200
@@ -41,9 +41,10 @@

 echo -n "checking for autoconf >= $AUTOCONF_REQUIRED_VERSION ... "
 if (autoconf --version) < /dev/null > /dev/null 2>&1; then
- VER=`autoconf --version \
+ VER=`autoconf2.50 --version \
          | grep -iw autoconf | sed "s/.* \([0-9.]*\)[-a-z0-9]*$/\1/"`
     check_version $VER $AUTOCONF_REQUIRED_VERSION
+ echo $VER
 else
     echo
     echo " You must have autoconf installed to compile $PROJECT."

Haha

[otto06217 (otto-kesselgulasch)]

Off Topic

ppastats via the launchpad API worked 'till May 20 2012 without any problems but since this date it's out of order.
Any hints?

Regards

Otto

[Bernd Zeimetz (bzed)]

On 06/21/2012 12:54 AM, otto06217 wrote:
> Off Topic

yes, offtopic.

> ppastats via the launchpad API worked 'till May 20 2012 without any problems but since this date it's out of order.
> Any hints?

don't abuse bug reports for such questions, there might be other people
who are annoyed by the large amount of mails already.

--
 Bernd Zeimetz Debian GNU/Linux Developer
 http://bzed.de http://www.debian.org
 GPG Fingerprint: ECA1 E3F2 8E11 2432 D485 DD95 EB36 171A 6FF9 435F

[Bernd Zeimetz (bzed)]

Please give this patch a try and let me know if it builds wherever you want it to build. I'lla apply it in Debian then so you can pull it.

AND PLEASE CONTACT ME NEXT TIME BEFORE MESSING WITH MY PACKAGES IN UBUNTU OR INTRODUCING CRAPPY UBUNTU VERSIONS OF THEM.

[Micah Gersten (micahg)]

@Bernd Zeimetz
First, I'm sorry we didn't ping you beforehand about this. Second, thank you for the patch, it works for us on precise and quantal.

[Bernd Zeimetz (bzed)]

gimp-plugin-registry (5.20120621) unstable; urgency=low

  * [83567039] Add patch to avoid calling deprecated g_thread_init.
               (LP: #1013003)

 -- Bernd Zeimetz <email address hidden> Thu, 21 Jun 2012 22:54:56 +020

Uploaded to unstable, up to you to get it synced to Ubuntu :)

[Micah Gersten (micahg)]

I'll take care of it as soon as LP imports the upload from Debian, thanks.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gimp-plugin-registry - 5.20120621

---------------
gimp-plugin-registry (5.20120621) unstable; urgency=low

  * [83567039] Add patch to avoid calling deprecated g_thread_init.
               (LP: #1013003)

 -- Bernd Zeimetz <email address hidden> Thu, 21 Jun 2012 22:54:56 +0200

[otto06217 (otto-kesselgulasch)]

Am 21.06.2012 10:58, schrieb Bernd Zeimetz:
> On 06/21/2012 12:54 AM, otto06217 wrote:
>> Off Topic
> yes, offtopic.
>
>> ppastats via the launchpad API worked 'till May 20 2012 without any problems but since this date it's out of order.
>> Any hints?
> don't abuse bug reports for such questions, there might be other people
> who are annoyed by the large amount of mails already.
>
>
Sorry

[otto06217 (otto-kesselgulasch)]

Am 22.06.2012 12:03, schrieb otto06217:
> Am 21.06.2012 10:58, schrieb Bernd Zeimetz:
>> On 06/21/2012 12:54 AM, otto06217 wrote:
>>> Off Topic
>> yes, offtopic.
Oh, my mistake, MIster Zeimetz.
>>
>>> ppastats via the launchpad API worked 'till May 20 2012 without any problems but since this date it's out of order.
>>> Any hints?
>> don't abuse bug reports for such questions, there might be other people
>> who are annoyed by the large amount of mails already.
You should reply:
Please don't abuse bug reports for such questions, there might be other
people who are annoyed by the large amount of mails already.
Instead of don't abuse bug reports for such questions, there might be
other people who are annoyed by the large amount of mails already.

Respect, Baby
Who do you think you are? God?

Best Regards, Mister

Otto

[Micah Gersten (micahg)]

Thanks a lot everyone for collaborating on this solution. While Debian and Ubuntu now benefit from the fix and the issue is closed, it would have been great if we all would have assumed best intentions throughout this bug report. On the internet, with language barriers and less ways to express emotions, it helps to stay focused, spend less time arguing, and leave everyone with a good experience.