User messages displayed on login page

Bug #1012467 reported by Gabriel Hurley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Gabriel Hurley

Bug Description

When something causes a user to be logged out while there are messages pending, those messages may be displayed on the login page out of context. This not only causes confusion, it could be a security breach if the message contains any sensitive information.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/8466

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/8466
Committed: http://github.com/openstack/horizon/commit/a5a1e4013542c64ebdbe7a01e43a773c7a8d3f21
Submitter: Jenkins
Branch: master

commit a5a1e4013542c64ebdbe7a01e43a773c7a8d3f21
Author: Gabriel Hurley <email address hidden>
Date: Tue Jun 12 19:30:45 2012 -0700

    Improved message handling.

      * Login page no longer displays user messages
        inappropriately. Instead, login errors are handled
        as form errors. Fixes bug 1012467.
      * Messages triggered during an AJAX call are no longer
        added to the standard message queue (which causes
        them to appear on subsequent unrelated requests).
        Instead, they are encoded and sent back with the AJAX
        response, allowing them to be displayed to the user
        client-side when they are relevant.
        Fixes bug 1008799.
      * Adds the last couple "compress" tags to the
        _scripts.html template to completely implement
        blueprint asset-compression.

    Change-Id: I967f32b44603ded7ec95bd0b86e7d997c6a8b352

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.