pptviewlib does not accept unicode filename

[Samuel Findlay]

If PowerPoint Viewer is being used by presentation plugin, loading a presentation file whose filename/path contains unicode (non-ASCII) characters causes a traceback:

--- Exception Traceback ---
Traceback (most recent call last):
  File "D:\OpenLP_Code\release-1.9.9\build\pyi.win32\OpenLP\outPYZ1.pyz\openlp.core.lib.mediamanageritem", line 342, in onFileClick
  File "D:\OpenLP_Code\release-1.9.9\build\pyi.win32\OpenLP\outPYZ1.pyz\openlp.core.lib.mediamanageritem", line 396, in validateAndLoad
  File "D:\OpenLP_Code\release-1.9.9\build\pyi.win32\OpenLP\outPYZ1.pyz\openlp.plugins.presentations.lib.mediaitem", line 194, in loadList
  File "D:\OpenLP_Code\release-1.9.9\build\pyi.win32\OpenLP\outPYZ1.pyz\openlp.plugins.presentations.lib.pptviewcontroller", line 128, in load_presentation
UnicodeEncodeError: 'ascii' codec can't encode characters in position 60-61: ordinal not in range(128)

Line 128 in load_presentation in pptviewcontroller uses str() on the filepath. This is due to a limitation of the C/C++ pptviewlib. It's OpenPPT function takes a *filename argument of type char. Thus it is unable to deal with unicode strings.

see http://www.support.openlp.org/issues/724

[WinXP SP3, OpenLP 1.9.9]

[Jonathan Corwin (j-corwin)]

Samuel, did you reproduce this? I tried with a non-ascii character filename but it worked fine. However I'm on Windows 7, not XP.

[Samuel Findlay (sfindlay)]

No I haven't. Still waiting on more information from the user. The bug
report was my deduction from looking at the code, but it may not be valid.

Will follow up.

---
Sent from my mobile
On Jun 21, 2012 7:00 AM, "Jonathan Corwin" <email address hidden>
wrote:

> Samuel, did you reproduce this? I tried with a non-ascii character
> filename but it worked fine. However I'm on Windows 7, not XP.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1012110
>
> Title:
> pptviewlib does not accept unicode filename
>
> Status in OpenLP - Worship Presentation Software:
> New
>
> Bug description:
> If PowerPoint Viewer is being used by presentation plugin, loading a
> presentation file whose filename/path contains unicode (non-ASCII)
> characters causes a traceback:
>
> --- Exception Traceback ---
> Traceback (most recent call last):
> File
> "D:\OpenLP_Code\release-1.9.9\build\pyi.win32\OpenLP\outPYZ1.pyz\openlp.core.lib.mediamanageritem",
> line 342, in onFileClick
> File
> "D:\OpenLP_Code\release-1.9.9\build\pyi.win32\OpenLP\outPYZ1.pyz\openlp.core.lib.mediamanageritem",
> line 396, in validateAndLoad
> File
> "D:\OpenLP_Code\release-1.9.9\build\pyi.win32\OpenLP\outPYZ1.pyz\openlp.plugins.presentations.lib.mediaitem",
> line 194, in loadList
> File
> "D:\OpenLP_Code\release-1.9.9\build\pyi.win32\OpenLP\outPYZ1.pyz\openlp.plugins.presentations.lib.pptviewcontroller",
> line 128, in load_presentation
> UnicodeEncodeError: 'ascii' codec can't encode characters in position
> 60-61: ordinal not in range(128)
>
> Line 128 in load_presentation in pptviewcontroller uses str() on the
> filepath. This is due to a limitation of the C/C++ pptviewlib. It's
> OpenPPT function takes a *filename argument of type char. Thus it is
> unable to deal with unicode strings.
>
> see http://www.support.openlp.org/issues/724
>
> [WinXP SP3, OpenLP 1.9.9]
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/openlp/+bug/1012110/+subscriptions
>

[Launchpad Janitor (janitor)]

[Expired for OpenLP because there has been no activity for 60 days.]

[Phill (phill-ridout)]

I can replicate this on Windows XP using the char 'ø' see: http://support.openlp.org/issues/2087

[Phill (phill-ridout)]

In 2.0 we're converting the strings to ASCII using str() as Pythoin 3 is unicode, str converts to unicode by default.

When changing 2.0 to use unicode powerpoint reports that it cannot find the file "c" this also happens in 2.1 (python 3) so I believe the dll is not handling unicode