Run blocking photo edit operations in background threads
Bug #1011710 reported by
Calum Pringle
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
gallery-app |
Fix Released
|
High
|
Unassigned | ||
gallery-app (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
When an image is cropped, even if the processing is instant, the transition from original image to the new, cropped one, should be smooth.
I suggest that upon selection of "ok", an activity spinner will fade in in the centre of the screen (for a minimum length of time e.g. 2s) whilst behind it the original image crossfades to that of the new, cropped image.
Attached is a screenshot showing this detail.
Related branches
lp:~schwann/gallery-app/gallery-edit-thread
- Gustavo Pichorim Boiko (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 894 lines (+457/-261)7 files modifiedsrc/media/media-source.h (+3/-1)
src/photo/CMakeLists.txt (+2/-0)
src/photo/photo-edit-thread.cpp (+285/-0)
src/photo/photo-edit-thread.h (+63/-0)
src/photo/photo.cpp (+82/-253)
src/photo/photo.h (+13/-7)
tests/unittests/stubs/photo_stub.cpp (+9/-0)
Changed in goodhope: | |
milestone: | none → alpha2 |
assignee: | nobody → Charles Lindsay (chaz-yorba) |
Changed in goodhope: | |
assignee: | Calum Pringle (calumpringle) → Chris Paul (chrispaul) |
Changed in goodhope: | |
milestone: | alpha2 → alpha3 |
Changed in goodhope: | |
milestone: | alpha3 → beta1 |
Changed in goodhope: | |
milestone: | beta1 → final |
summary: |
- Crop progress activity spinner + Crop progress and auto-enhance activity spinner |
summary: |
- Crop progress and auto-enhance activity spinner + Run blocking operations in background threads |
Changed in goodhope: | |
importance: | Undecided → High |
tags: | added: performance |
Changed in goodhope: | |
assignee: | nobody → Lucas Beeler (lucas-yorba) |
Changed in goodhope: | |
assignee: | Lucas Beeler (lucas-yorba) → nobody |
tags: | removed: bug |
summary: |
- Run blocking operations in background threads + Run blocking photo edit operations in background threads |
Changed in goodhope: | |
importance: | High → Medium |
information type: | Private → Public |
affects: | goodhope → gallery-app |
Changed in gallery-app: | |
milestone: | final → none |
Changed in gallery-app: | |
importance: | Medium → High |
Changed in gallery-app: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Once we implement proper "recrop", where after you've cropped once and you reenter the crop tool you're shown the original with the crop rectangle preset to where you had previously cropped, are we going to do anything for the mirror case of going from the cropped to the original? In other words, you're describing what to do when you hit crop and the photo shrinks to the cropped region, but what should we do when you enter the crop tool and the photo expands to the original size?
Also I'll need the spinning graphic to implement this feature -- I'm afraid making a dummy spinning gif is beyond my level of expertise in GIMP.