Run blocking photo edit operations in background threads

Bug #1011710 reported by Calum Pringle
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gallery-app
Fix Released
High
Unassigned
gallery-app (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

When an image is cropped, even if the processing is instant, the transition from original image to the new, cropped one, should be smooth.

I suggest that upon selection of "ok", an activity spinner will fade in in the centre of the screen (for a minimum length of time e.g. 2s) whilst behind it the original image crossfades to that of the new, cropped image.

Attached is a screenshot showing this detail.

Tags: performance

Related branches

Revision history for this message
Calum Pringle (calumpringle) wrote :
Adam Dingle (adam-yorba)
Changed in goodhope:
milestone: none → alpha2
assignee: nobody → Charles Lindsay (chaz-yorba)
Revision history for this message
Charles Lindsay (chaz-yorba) wrote :

Once we implement proper "recrop", where after you've cropped once and you reenter the crop tool you're shown the original with the crop rectangle preset to where you had previously cropped, are we going to do anything for the mirror case of going from the cropped to the original? In other words, you're describing what to do when you hit crop and the photo shrinks to the cropped region, but what should we do when you enter the crop tool and the photo expands to the original size?

Also I'll need the spinning graphic to implement this feature -- I'm afraid making a dummy spinning gif is beyond my level of expertise in GIMP.

Changed in goodhope:
assignee: Charles Lindsay (chaz-yorba) → Calum Pringle (calumpringle)
status: New → Incomplete
Revision history for this message
Calum Pringle (calumpringle) wrote :

Yes the opposite direction should also have a brief spinner and crossfade. The spinner will be part of the toolkit, I'll ask Chris to provide something though.

Adam Dingle (adam-yorba)
Changed in goodhope:
assignee: Calum Pringle (calumpringle) → Chris Paul (chrispaul)
Adam Dingle (adam-yorba)
Changed in goodhope:
milestone: alpha2 → alpha3
Revision history for this message
Adam Dingle (adam-yorba) wrote :

Once the spinner is available we'll use it both for cropping and for autoenhance (see bug #1018972), where we're currently using a placeholder spinner graphic. On that bug, Eric wrote

    note that the spinner graphic needs to be an MNG formatted animation, because that's what Qt supports.

So, Chris: if you can give us an MNG that would be great. If not, we can probably figure out how to convert from another format (such as a series of PNGs).

Revision history for this message
Eric Gregory (eric-yorba) wrote :

For the record, ImageMagick/GraphicsMagick can build an MNG from a series of PNGs.

Say you have frame01.png, frame02.png, etc. and want a 100ms delay between each frame. The command to build the animation is:
convert -delay 100 frame*.png animation.mng

Adam Dingle (adam-yorba)
Changed in goodhope:
milestone: alpha3 → beta1
Adam Dingle (adam-yorba)
Changed in goodhope:
milestone: beta1 → final
Jim Nelson (yorba-jim)
summary: - Crop progress activity spinner
+ Crop progress and auto-enhance activity spinner
Revision history for this message
Jim Nelson (yorba-jim) wrote : Re: [sdk] Crop progress and auto-enhance activity spinner

I believe a progress bar was added to the SDK. Presumably a spinner widget should be added as well.

summary: - Crop progress and auto-enhance activity spinner
+ [sdk] Crop progress and auto-enhance activity spinner
Changed in goodhope:
status: Incomplete → Confirmed
assignee: Chris Paul (chrispaul) → nobody
Revision history for this message
Jim Nelson (yorba-jim) wrote : Re: Crop progress and auto-enhance activity spinner

Eric informs me that a spinner is in the SDK. Now Gallery needs to display it while running the editing operations in the background.

summary: - [sdk] Crop progress and auto-enhance activity spinner
+ Crop progress and auto-enhance activity spinner
summary: - Crop progress and auto-enhance activity spinner
+ Run blocking operations in background threads
Changed in goodhope:
importance: Undecided → High
Jim Nelson (yorba-jim)
tags: added: performance
Jim Nelson (yorba-jim)
Changed in goodhope:
assignee: nobody → Lucas Beeler (lucas-yorba)
Jim Nelson (yorba-jim)
Changed in goodhope:
assignee: Lucas Beeler (lucas-yorba) → nobody
tags: removed: bug
summary: - Run blocking operations in background threads
+ Run blocking photo edit operations in background threads
Changed in goodhope:
importance: High → Medium
information type: Private → Public
affects: goodhope → gallery-app
Changed in gallery-app:
milestone: final → none
Changed in gallery-app:
importance: Medium → High
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:gallery-app at revision None, scheduled for release in gallery-app, milestone ubuntu-13.04-month-5

Changed in gallery-app:
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gallery-app - 0.0.67+13.10.20130729-0ubuntu1

---------------
gallery-app (0.0.67+13.10.20130729-0ubuntu1) saucy; urgency=low

  [ Guenter Schwann ]
  * Run edit operations in a background task. (LP: #1011710)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 788
 -- Ubuntu daily release <email address hidden> Mon, 29 Jul 2013 08:17:31 +0000

Changed in gallery-app (Ubuntu):
status: New → Fix Released
Changed in gallery-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.