Spaces at the beginning and end of strings not allowed

Bug #1009639 reported by Vish Ishaya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-common
Fix Released
Undecided
Vish Ishaya

Bug Description

There is no way to create a configuration string that has a space at the beginning or end because we strip() the input. This means that certain default options cannot be replicated in the config file. For example, the following option in nova cannot be modified properly as it requires an eol space for proper output:

   cfg.StrOpt('instance_format',
               default='[instance: %(uuid)s] ',

We should allow for options (at least string options) to be quoted so we can handle bol and eol spaces.

Changed in openstack-common:
status: New → In Progress
assignee: nobody → Vish Ishaya (vishvananda)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/8240

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to openstack-common (master)

Reviewed: https://review.openstack.org/8240
Committed: http://github.com/openstack/openstack-common/commit/83044a72815ba2a7cec1e6a343c6eeb091c68a30
Submitter: Jenkins
Branch: master

commit 83044a72815ba2a7cec1e6a343c6eeb091c68a30
Author: Vishvananda Ishaya <email address hidden>
Date: Wed Jun 6 11:26:18 2012 -0700

    Adds support for bol and eol spaces to ini files

      * Fixes bug 1009639
      * Adds tests

    Change-Id: Id00563dfcc6f143c3e86ec380d66cffc967b8c48

Changed in openstack-common:
status: In Progress → Fix Committed
Mark McLoughlin (markmc)
Changed in openstack-common:
milestone: none → 2012.2
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.