Unused imports cleanup

Bug #1008023 reported by Zhongyue Luo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Zhongyue Luo

Bug Description

Clean up unused imports found by pylint

find . -type f -name "*py" -exec ../.venv/bin/pylint -r n {} \; | grep -E "Unused imp|^\*"

************* Module volume.manager
W: 53,0: Unused import volume_types
W: 50,0: Unused import rpc
************* Module test
W: 28,0: Unused import shutil
W: 27,0: Unused import os
************* Module image.s3
W: 39,0: Unused import rpc
************* Module network.api
W: 21,0: Unused import exception
W: 26,0: Unused import rpc_common
************* Module network.l3
W: 18,0: Unused import random
************* Module network.quantum.fake_client
W: 19,0: Unused import copy
************* Module network.quantum.client
W: 20,0: Unused import json
************* Module api.openstack.compute.contrib.certificates
W: 26,0: Unused import rpc
************* Module api.sizelimit
W: 24,0: Unused import context
************* Module db.sqlalchemy.migrate_repo.versions.084_quotas_unlimited
W: 18,0: Unused import migrate
************* Module db.sqlalchemy.migrate_repo.versions.096_recreate_dns_domains
W: 18,0: Unused import select
************* Module db.sqlalchemy.migrate_repo.versions.082_essex
W: 23,0: Unused import Set
************* Module tests.glance.stubs
W: 22,0: Unused import exception
************* Module tests.test_flags
W: 21,0: Unused import tempfile
W: 20,0: Unused import os
************* Module tests.test_nova_manage
W: 19,0: Unused import json
************* Module tests.integrated.test_extensions
W: 18,0: Unused import extensions
************* Module tests.consoleauth.test_consoleauth
W: 32,0: Unused import utils
W: 27,0: Unused import db
W: 30,0: Unused import importutils
************* Module tests.test_log
W: 4,0: Unused import sys
************* Module tests.network.test_manager
W: 26,0: Unused import flags
************* Module tests.test_xenapi
W: 31,0: Unused import vm_states
W: 25,0: Unused import mox
W: 30,0: Unused import task_states
************* Module tests.test_libvirt_vif
W: 22,0: Unused import firewall
W: 24,0: Unused import connection
************* Module tests.api.openstack.test_wsgi
W: 12,0: Unused import utils
W: 8,0: Unused import nova
W: 4,0: Unused import json
************* Module tests.api.openstack.compute.test_flavors
W: 30,0: Unused import utils
************* Module tests.api.openstack.compute.test_extensions
W: 33,0: Unused import utils
************* Module tests.api.openstack.compute.contrib.test_scheduler_hints
W: 20,0: Unused import wsgi
W: 19,0: Unused import extensions
************* Module tests.api.openstack.compute.contrib.test_floating_ips
W: 27,0: Unused import rpc_common
************* Module tests.api.openstack.compute.contrib.test_disk_config
W: 22,0: Unused import wsgi
W: 21,0: Unused import extensions
************* Module tests.api.ec2.test_ec2_validate
W: 23,0: Unused import inst_state
W: 22,0: Unused import ec2utils
W: 26,0: Unused import vm_states
W: 24,0: Unused import power_state
W: 19,0: Unused import webob
************* Module tests.test_libvirt
W: 24,0: Unused import sys
************* Module tests.fake_network
W: 24,0: Unused import fake_network_cache_model
************* Module tests.test_melange_ipam_lib
W: 19,0: Unused import exception
************* Module tests.scheduler.test_filter_scheduler
W: 26,0: Unused import test
************* Module tests.scheduler.test_scheduler
W: 32,0: Unused import notifications
************* Module tests.test_imagecache
W: 31,0: Unused import image
************* Module tests.rpc.test_common
W: 30,0: Unused import common
W: 23,0: Unused import context
W: 27,0: Unused import rpc_amqp
************* Module tests.test_utils
W: 30,0: Unused import lockfile
************* Module wsgi
W: 36,0: Unused import utils
************* Module scheduler.driver
W: 37,0: Unused import rpc_common
************* Module scheduler.filters.trusted_filter
W: 56,0: Unused import utils
************* Module notifier.api
W: 16,0: Unused import inspect
************* Module vnc.xvp_proxy
W: 34,0: Unused import rpc
************* Module compute.api
W: 50,0: Unused import rpc
W: 45,0: Unused import cfg
************* Module compute.utils
W: 19,0: Unused import nova
W: 27,0: Unused import utils
W: 24,0: Unused import network_model
W: 23,0: Unused import network
************* Module virt.baremetal.tilera
W: 25,0: Unused import os
************* Module virt.libvirt.connection
W: 49,0: Unused import time
************* Module virt.libvirt.imagecache
W: 31,0: Unused import compute
W: 32,0: Unused import db_context
************* Module virt.libvirt.firewall
W: 24,0: Unused import db
W: 23,0: Unused import context
W: 30,0: Unused import netutils
W: 27,0: Unused import utils
************* Module virt.xenapi.vmops
W: 36,0: Unused import vm_states
W: 35,0: Unused import task_states
************* Module virt.xenapi.volume_utils
W: 30,0: Unused import utils
W: 26,0: Unused import db
W: 27,0: Unused import exception
W: 25,0: Unused import context
************* Module virt.images
W: 24,0: Unused import errno
************* Module virt.vmwareapi_conn
W: 40,0: Unused import db
W: 39,0: Unused import context
************* Module rpc.common
W: 25,0: Unused import cfg
W: 22,0: Unused import sys
************* Module testing.runner
W: 78,0: Unused import cfg
W: 76,0: Unused import flags

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/8095

Changed in nova:
status: New → In Progress
Zhongyue Luo (zyluo)
description: updated
description: updated
Zhongyue Luo (zyluo)
description: updated
Zhongyue Luo (zyluo)
description: updated
Brian Waldon (bcwaldon)
summary: - Unused imports cleanup (folsom-2)
+ Unused imports cleanup
Changed in nova:
milestone: none → folsom-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/8095
Committed: http://github.com/openstack/nova/commit/6228acd7ff3b20460d8c6fae9ab7c773ab38529a
Submitter: Jenkins
Branch: master

commit 6228acd7ff3b20460d8c6fae9ab7c773ab38529a
Author: Zhongyue Luo <email address hidden>
Date: Sun Jun 3 13:23:11 2012 +0800

    Unused imports cleanup (folsom-2)

    Fixes bug #1008023

    Change-Id: Ifb8ecbb7430fdabd7b5d81ab23df66942abd9cb7

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.