nova libvirt driver requires iscsi initiator name regardless of using it in volume drivers

Bug #1007084 reported by Joseph Heck
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Unassigned
Grizzly
Fix Released
Medium
Ruby Loo

Bug Description

The nova libvirt driver requires the file /etc/iscsi/initiatorname.iscsi to exist and be valid, regardless of backend volume driver - many of which do not use iscsi. This leaves a extra dependency in place that isn't needed.

This seems like it would be better organized if the volume driver looked up the information it needed rather than routing through methods on the compute manager.

Tags: libvirt
Revision history for this message
Vish Ishaya (vishvananda) wrote :

the problem is that the manager (and probably in the future the api) is the one that calls initialize_connection. It has to pass in info about where the connection will be coming from, but perhaps we could make initiator optional, as in if it can't find the initiator name, it won't pass it in initialize_connection. If the receiving volume driver needs iscsi and it isn't set it can return an error.

Would that work?

Changed in nova:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Joseph Heck (heckj) wrote :

Vish - sounds good. I'll see about cobbling a patch that does that.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/32407

Changed in nova:
assignee: nobody → Xavier Queralt (xqueralt)
status: Triaged → In Progress
melanie witt (melwitt)
tags: added: libvirt
Revision history for this message
Xavier Queralt (xqueralt-deactivatedaccount) wrote :

I've added two patches to gerrit that implement what vishvananda suggests:

Don't make nova-compute depend on iSCSI: https://review.openstack.org/#/c/32407/
Return an error if initiator is not set but needed: https://review.openstack.org/#/c/32408/

A review would be much appreciated.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/32407
Committed: http://github.com/openstack/nova/commit/3ba0c171c0b6f3516662bc0ab660b14cd6d34d8a
Submitter: Jenkins
Branch: master

commit 3ba0c171c0b6f3516662bc0ab660b14cd6d34d8a
Author: Xavier Queralt <email address hidden>
Date: Mon Jun 10 16:06:40 2013 +0200

    Don't make nova-compute depend on iSCSI

    Because not all volume drivers require iSCSI it makes sense to not
    set the initiator in the connector and let the volume drivers
    return an error if iSCSI is required.

    bug #1007084

    Change-Id: I5da472e5013fdc0c733ecb12b919c1068873bdc6

Changed in nova:
status: In Progress → Fix Committed
tags: added: grizzly-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/grizzly)

Fix proposed to branch: stable/grizzly
Review: https://review.openstack.org/33812

Thierry Carrez (ttx)
Changed in nova:
milestone: none → havana-2
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (stable/grizzly)

Reviewed: https://review.openstack.org/33812
Committed: http://github.com/openstack/nova/commit/9d783b648878e386265cef5b82a931ed677ded43
Submitter: Jenkins
Branch: stable/grizzly

commit 9d783b648878e386265cef5b82a931ed677ded43
Author: Xavier Queralt <email address hidden>
Date: Mon Jun 10 16:06:40 2013 +0200

    Don't make nova-compute depend on iSCSI

    Because not all volume drivers require iSCSI it makes sense to not
    set the initiator in the connector and let the volume drivers
    return an error if iSCSI is required.

    bug #1007084

    Change-Id: I5da472e5013fdc0c733ecb12b919c1068873bdc6
    (cherry picked from commit 3ba0c171c0b6f3516662bc0ab660b14cd6d34d8a)

tags: added: in-stable-grizzly
Alan Pevec (apevec)
tags: removed: grizzly-backport-potential in-stable-grizzly
Thierry Carrez (ttx)
Changed in nova:
milestone: havana-2 → 2013.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.