linux plugin agent's config file is not consistent with the common config module

Bug #1006684 reported by yong sheng gong
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Gary Kotton

Bug Description

linux agent's config file reads:
[LINUX_BRIDGE]
# This is the interface connected to the switch on your Quantum network
physical_interface = eth1

but common config module reads:
def parse(config_file):
    conf = cfg.ConfigOpts(default_config_files=[config_file])
    conf(args=[])
    conf.register_opts(vlan_opts, "VLANS")
    conf.register_opts(database_opts, "DATABASE")
    conf.register_opts(bridge_opts, "BRIDGE")
    conf.register_opts(agent_opts, "AGENT")
    return conf

Should we change LINUX_BRIDGE into BRIDGE? if yes, make sure not to break devstack.
also it seems the common config module is just for linux bridge agent's config file, why should be put it into common config module?
Will we format all other plugin's config file according to it?

Revision history for this message
Sumit Naiksatam (snaiksat) wrote :

Good catch, this probably crept in on account of the recent changes. It should be changed in one of the places, I would recommend changing BRIDGE to LINUX_BRIDGE. Also, this does not affect devstack.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7965

Changed in quantum:
assignee: nobody → Gary Kotton (garyk)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/7965
Committed: http://github.com/openstack/quantum/commit/5c0fc495ffcb0f40294f39f3706648484cf00be0
Submitter: Jenkins
Branch: master

commit 5c0fc495ffcb0f40294f39f3706648484cf00be0
Author: Yong Sheng Gong <email address hidden>
Date: Wed May 30 13:59:52 2012 +0800

    Fix linux bridge section name
    Bug #1006684

    Change-Id: Ic7a97179d6fbb90f8c7f544a5725e1ff56fd9653

Changed in quantum:
status: In Progress → Fix Committed
Gary Kotton (garyk)
Changed in quantum:
milestone: none → folsom-2
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.