binaries should report versions

Bug #1004966 reported by dan wendlandt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Harsh Prasad

Bug Description

Both our server and client binaries do not seem to have good output describing their version. This is particularly important for the server.

danwent@ubuntu:~/quantum$ quantum-server --version
%quantum-server VERSION

danwent@ubuntu:~/quantum$ quantum --version
Usage: quantum [OPTIONS] <command> [args]

quantum: error: --version option requires an argument

dan wendlandt (danwent)
tags: added: low-hanging-fruit
Revision history for this message
yong sheng gong (gongysh) wrote :

Hi,
 Current status:
clients:
glance client has --version to display version
nova client has no such option
keystone client has no such option
quantum client has this option, but used to select which api is used.

servers:
nova servers such as nova-compute etc have no such option
keystone-all has no such option
glance api has this option to show version and exit
quantum-server has, but with wrong text output.

So I think this issue is just needed to fix quantum-server side.

Revision history for this message
Harsh Prasad (prasad-tanay) wrote :

Hi,

I would like to fix this bug to get acquanted to quantum code, but i am fairly new to quantum and would like some help. Can you please guide me about where to find the required file and function.

Revision history for this message
Harsh Prasad (prasad-tanay) wrote :

Would the output of the following format acceptable for version information:

tanay@tanay-Inspiron-1545:~/openstack/quantum$ quantum-server --version
%quantum-server 2012.2-dev

Please tell if version is to be given in some particular or different format.

Changed in quantum:
assignee: nobody → Harsh Prasad (prasad-tanay)
Revision history for this message
dan wendlandt (danwent) wrote :

Hi harsh, yes, that looks great.

Yong, I agree, only fixing the server makes sense. I hadn't realized that the --version flag was used by the client to let the client specify the API version. Now the client's output makes more sense.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/8111

Changed in quantum:
status: New → In Progress
Revision history for this message
Aziz (m-a-aziz) wrote : Re: [Bug 1004966] Re: binaries should report versions

Hi Harsh,

  The page https://review.openstack.org/8111 doesnt seem to be present, can
you please check the URL?

Regards,
Aziz.

On Mon, Jun 4, 2012 at 8:50 AM, OpenStack Hudson <<email address hidden>
> wrote:

> Fix proposed to branch: master
> Review: https://review.openstack.org/8111
>
> ** Changed in: quantum
> Status: New => In Progress
>
> --
> You received this bug notification because you are subscribed to
> quantum.
> Matching subscriptions: OpenStack-Quantum-virtual-network
> https://bugs.launchpad.net/bugs/1004966
>
> Title:
> binaries should report versions
>
> Status in OpenStack Quantum (virtual network service):
> In Progress
>
> Bug description:
> Both our server and client binaries do not seem to have good output
> describing their version. This is particularly important for the
> server.
>
>
> danwent@ubuntu:~/quantum$ quantum-server --version
> %quantum-server VERSION
>
> danwent@ubuntu:~/quantum$ quantum --version
> Usage: quantum [OPTIONS] <command> [args]
>
> quantum: error: --version option requires an argument
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/quantum/+bug/1004966/+subscriptions
>

--
Md.Abdul Aziz
BTech,CSE,IIIT -HYD

Cisco Systems,
Bangalore.

Revision history for this message
dan wendlandt (danwent) wrote :

url works for me.

Revision history for this message
Harsh Prasad (prasad-tanay) wrote :

@Aziz: I guess you will have to login.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to quantum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/8386

Changed in quantum:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to quantum (master)

Reviewed: https://review.openstack.org/8386
Committed: http://github.com/openstack/quantum/commit/56d6f9ce860904c178ff63ab335185030b9175a5
Submitter: Jenkins
Branch: master

commit 56d6f9ce860904c178ff63ab335185030b9175a5
Author: Harsh Prasad <email address hidden>
Date: Mon Jun 11 12:25:18 2012 +0530

    Binaries should report versions.

    Bug #1004966.

    Added the version_string() and removed the extra '%' for the quantum-server binary.

    Change-Id: Ic1f3e2eb9a742bdfb63df6f901e579349f04f3ec

Thierry Carrez (ttx)
Changed in quantum:
milestone: none → folsom-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-2 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.