Remove plans block javascript from template

Bug #1002168 reported by Richard Mansfield
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Richard Mansfield

Bug Description

By putting more javascript into the static plansblock.js file, it's possible to remove the script element from the template. This is better for exports, which should not include javascript designed for the site. Putting the entire block initialisation into a separate function also allows the pagination links to be made available when a new plans block is first dragged into a page.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/1226
Committed: http://gitorious.org/mahara/mahara/commit/f4cc34f0356e18dd4ac9a8be6be0ad7a14211403
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit f4cc34f0356e18dd4ac9a8be6be0ad7a14211403
Author: Richard Mansfield <email address hidden>
Date: Mon May 21 18:40:03 2012 +1200

    Remove plans block javascript from template (bug #1002168)

    By putting more javascript into the static plansblock.js file, it's
    possible to remove the script element from the template. This is
    better for exports, which should not include javascript designed for
    the site. Putting the entire block initialisation into a separate
    function also allows the pagination links to be made available when a
    new plans block is first dragged into a page.

    Change-Id: I7a5e6448c14272660b317b55b4db7cd2829576f7
    Signed-off-by: Richard Mansfield <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iJwEAQECAAYFAlCbHO8ACgkQuMoJ2LQ3zxH8TAP/YN4BiCJZsn5a899/0UzV31Qg
lM8LXAwZWa6zFv6t0BQUHCqe6eFK9wPp51qgCWWXjUZ3vvvVcsyeWp6626aBFKSU
pCQXI9E7huPw802nJQ9WcZXRBUmgw87ww72Tx4mybnu7SPSrkZgXdnPGSMwDs89N
oWvTpl7Xuac48e6p0lU=
=ouU+
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.