Ramping pitch bend doesn't follow direction

[Sean M. Pappalardo]

Ramping pitch bend doesn't take rate_dir into account, causing the temporary bend buttons in the GUI to work opposite of their labeling when the direction is set for down to increase speed.

Non-ramping pitch bend works as expected.

[RJ Skerry-Ryan (rryan)]

Ramping pitch bend already seems to follow rate-dir.

[Sean M. Pappalardo (pegasus-renegadetech)]

Testing with 1.11 r3485, the problem still exists: with ramping on, rate_temp_up actually slows down the track when the pitch slider is set for up to be slower and down to be faster. (This also affects controllers.) Turning off ramping works as expected.

[RJ Skerry-Ryan (rryan)]

"rate_temp_up actually slows down the track when the pitch slider is set for up to be slower and down to be faster"

You just described the correct behavior. Do you mean that it's backwards?

[Sean M. Pappalardo (pegasus-renegadetech)]

Oh, I see the confusion here: I'm taking rate_temp_up to mean "temporarily increase the speed." Since that's the only CO everyone uses for pitch bending, I submit that that should be the behavior. By that measure, it's backwards with the pitch slider direction inverted and ramping on.

[RJ Skerry-Ryan (rryan)]

The rate-dir preference exists so that skins and controllers attach one button to rate_temp_up and one button to rate_temp_down and then the preference options toggles the direction without having to change the skin mapping or controller binding.

If rate_temp_up always meant "increase the speed" then the burden of implementing the preference option would be on the skin and preset authors since they would have to rebind their mapping to rate_temp_down when the preference option changed. It's better that it's transparent and rate_temp_up means the up/right-facing button and rate_temp_down means the down/left facing button.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6460