Nova/Quantum Integration broken due to typo in serializer

Bug #1000887 reported by dan wendlandt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
dan wendlandt
neutron
Fix Released
Critical
dan wendlandt

Bug Description

The bug seems to have been introduced by an error in a blanket changeset to switch Nova from using json to jasonutils. During that translation, a "return" statement was dropped, meaning the serializer always returned Null regardless of what data was pushed in. See: https://github.com/openstack/nova/commit/ba76b954e69de56f76f9db5cade1780bc351be67#L5L42

dan wendlandt (danwent)
Changed in nova:
status: New → In Progress
assignee: nobody → dan wendlandt (danwent)
Changed in quantum:
assignee: nobody → dan wendlandt (danwent)
importance: Undecided → Critical
milestone: none → folsom-1
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7550

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/7550
Committed: http://github.com/openstack/nova/commit/a5d06c2d12135f91aa2616b3bb8d28aa14c217ca
Submitter: Jenkins
Branch: master

commit a5d06c2d12135f91aa2616b3bb8d28aa14c217ca
Author: Dan Wendlandt <email address hidden>
Date: Wed May 16 20:19:36 2012 -0700

    fixes typo that completely broken Quantum/Nova integration

    bug 1000887

    fixes bug introduced in ba76b954e69de56f76f9db5cade1780bc351be67 that
    prevented the serializer in the Quantum client code from correctly
    serializing request body data. Instead, the serializer always returned
    None, meaning that requests would have no body, causing the Quantum
    server to return a 400.

    Change-Id: I410fb408435da8774f418f0e62ffb59eac2354f3

Changed in nova:
status: In Progress → Fix Committed
dan wendlandt (danwent)
Changed in quantum:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in quantum:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: none → folsom-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in quantum:
milestone: folsom-1 → 2012.2
Thierry Carrez (ttx)
Changed in nova:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.