test_invalid_auth_url shouldn't hit arbitrary web server

Bug #1000828 reported by Mark Washenberger
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Low
Mark Washenberger

Bug Description

Running test on a box that attempts to redirect arbitrary urls breaks glance functional tests.

======================================================================
ERROR: test_invalid_auth_url (glance.tests.unit.test_auth.TestKeystoneAuthPlugin)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/var/lib/jenkins/custom_workspaces/glance/glance/tests/unit/test_auth.py", line 178, in test_invalid_auth_url
    plugin.authenticate()
  File "/var/lib/jenkins/custom_workspaces/glance/glance/common/auth.py", line 128, in authenticate
    _authenticate(auth_url)
  File "/var/lib/jenkins/custom_workspaces/glance/glance/common/auth.py", line 120, in _authenticate
    self._v2_auth(token_url)
  File "/var/lib/jenkins/custom_workspaces/glance/glance/common/auth.py", line 253, in _v2_auth
    raise Exception(_('Unexpected response: %s') % resp.status)
Exception: Unexpected response: 302

This is just silly! The test shouldn't actually be hitting http://localhost/badauthurl :-)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7548

Changed in glance:
assignee: nobody → Mark Washenberger (markwash)
status: New → In Progress
Brian Waldon (bcwaldon)
Changed in glance:
importance: Undecided → Low
milestone: none → folsom-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/7548
Committed: http://github.com/openstack/glance/commit/457bbfbde4c4a6dc60792a85f133b288c7347337
Submitter: Jenkins
Branch: master

commit 457bbfbde4c4a6dc60792a85f133b288c7347337
Author: Mark Washenberger <email address hidden>
Date: Thu May 17 11:59:05 2012 -0400

    Stubout httplib to avoid actual http calls

    Fixes bug #1000828

    - Added some additional test code cleanup

    Change-Id: I0589aa22d8e4b835a1d8d72e47ba5d1ceb982aa8

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in glance:
milestone: folsom-1 → 2012.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.