Return value of shell commands is not checked by plugins
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
neutron |
Fix Released
|
Undecided
|
Gary Kotton |
Bug Description
Plugin agents (linuxbridge, ovs, ryu) use a copied implementation of run_cmd to execute shell commands. None of the implementations check the return value of an executed command, which has the potential to violate the dictates of 'fail fast' and complicate debugging.
As a simple example, a missing command will normally cause Popen to raise OSError. If a root_helper like sudo is used, however, no such error is raised and the exit code and/or stderror output are the only indications that something is wrong. None of the plugins check the exit code or stderr output by default.
nova.util.execute() is the benchmark here - exit codes are checked by default, and can only be ignored on a code-by-code basis.
summary: |
- Return value of shell commands is not checked + Return value of shell commands is not checked by plugins |
description: | updated |
Changed in quantum: | |
assignee: | nobody → Juliano Martinez (juliano-martinez) |
Changed in quantum: | |
status: | In Progress → Fix Committed |
Changed in quantum: | |
status: | Fix Committed → In Progress |
Changed in quantum: | |
assignee: | Juliano Martinez (ncode) → Gary Kotton (garyk) |
status: | Fix Committed → In Progress |
Changed in quantum: | |
milestone: | none → folsom-2 |
Changed in quantum: | |
status: | Fix Committed → Fix Released |
Changed in quantum: | |
milestone: | folsom-2 → 2012.2 |
Fix proposed to branch: master /review. openstack. org/8033
Review: https:/