The patch in launchpadBugs/HTMLOperations.py is simple enough - nice work.
Some reservations I personally have:
- shipping external code in lpbugs - I'm not extremely fond of it. I'd much prefer to ship it in a separate package where it gets updated regularly, etc.
- verbose=True - I'd rather this was False - tools/scripts (which might pipe the output somewhere else) should have to enable it
- my gut feeling is, that the output is too verbose - can we change this somehow so that the percentage of visited bugs is reflected in the progressbar and not every attachment?
If we package python-progressbar, it'd need to be reviewed for main inclusion, as python-launchpad-bugs would depend on it. I don't know if that's at all possible, but could we have it as a dependency of bughelper? (it doesn't feel so much python-lp-bugs related to me).
The patch in launchpadBugs/ HTMLOperations. py is simple enough - nice work.
Some reservations I personally have:
- shipping external code in lpbugs - I'm not extremely fond of it. I'd much prefer to ship it in a separate package where it gets updated regularly, etc.
- verbose=True - I'd rather this was False - tools/scripts (which might pipe the output somewhere else) should have to enable it
- my gut feeling is, that the output is too verbose - can we change this somehow so that the percentage of visited bugs is reflected in the progressbar and not every attachment?
If we package python-progressbar, it'd need to be reviewed for main inclusion, as python- launchpad- bugs would depend on it. I don't know if that's at all possible, but could we have it as a dependency of bughelper? (it doesn't feel so much python-lp-bugs related to me).