Comment 8 for bug 1932313

Revision history for this message
Bryce Harrington (bryce) wrote :

Confirmed Dan's findings. His patch reduces the failure+error count significantly, but as he mentions a few issues remain, like:

1. ModuleNotFoundError: No module named 'breezy.testingplugins'

2. KeyError in _get_cmd_object

995.171 brz arguments: ['not-a-command']

Traceback (most recent call last):
  File "/home/bryce/pkg/Breezy/ubuntu-impish/breezy-3.2.1/breezy/commands.py", line 296, in get_cmd_object
    return _get_cmd_object(cmd_name, plugins_override)
  File "/home/bryce/pkg/Breezy/ubuntu-impish/breezy-3.2.1/breezy/commands.py", line 337, in _get_cmd_object
    raise KeyError
KeyError

3. ModuleNotFoundError: No module named 'breezy.testingplugins.test_foo'

4. ModuleNotFoundError: No module named 'breezy.testingplugins.brz-bad plugin-name'

Unable to load 'brz-bad plugin-name.' in '/tmp/testbzr-6co5pg3w.tmp/breezy.tests.test_plugins.TestLoadingPlugins.test_plugin_with_bad_name_does_not_load/work' as a plugin because the file path isn't a valid module name; try renaming it to 'bad_plugin_name_'.

5. '.' != CWD

a = "Unable to load plugin 'some_error' from '.': bad\n"
b = ("Unable to load plugin 'some_error' from "
 "'/tmp/testbzr-6co5pg3w.tmp/breezy.tests.test_plugins.TestLoadingPlugins.test_plugin_with_error/work': "
 'bad\n')

6. ModuleNotFoundError: No module named 'breezy.testingplugins.plugin'

983.683 Unable to load plugin 'plugin' from 'first': No module named 'breezy.testingplugins.plugin'
 WARNING Unable to load plugin 'plugin' from 'first': No module named 'breezy.testingplugins.plugin'
983.684 removed breezy.testingplugins from sys.modules