Comment 13 for bug 129307

Revision history for this message
ChriS (christophe-troestler) wrote :

Attached is a new bundle that differs a bit from the previous one in -- I believe -- a better code factorization.

> - you changed the bzr behavior, so you need tests to avoid future regressions,
> - you fixed a bug, so we like at least one test failing before your modifications and succeeding after your modifications,

I have started to do so in the attached bundle but I could really use some help for these.

> - be aware that some plugins use or redefine this method (foreign
> VCS plugins as bzr-svn, bzr-hg, bzr-git, etc) so it will be nicer
> for them if you could find a way to stay compatible,

If you are takling about find_format, I did not find any occurrence of
it in bzr-svn.

> - it seems a bit strange that you need to modify workingtree at all,
> but other reviewers may know better than me.

This is because .bzr/checkout/format is read (which may be redirected too).

BTW,

 bzr co http://users.skynet.be/Pierre.Brukier/anum/projet

also works with the patch.