JavaScript should be compatible with other libraries than jQuery

Bug #712462 reported by shenzhuxi
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Internet Archive BookReader
Fix Released
Medium
mangtronix

Bug Description

I'm working on http://drupal.org/project/fileviewer And I think this should be considered in bookreader's codes.

http://drupal.org/update/modules/6/7#javascript_compatibility Javascript should be made compatible with other libraries than jQuery by adding a small wrapper around your existing code:
(function ($) { // Original JavaScript code. })(jQuery);

Tags: jquery
mangtronix (mang)
Changed in bookreader:
assignee: nobody → mangtronix (mang)
importance: Undecided → Medium
milestone: none → codesprint
status: New → Confirmed
mangtronix (mang)
Changed in bookreader:
status: Confirmed → Triaged
mangtronix (mang)
Changed in bookreader:
milestone: codesprint → cleanup
Revision history for this message
shenzhuxi (shenzhuxi) wrote :

Just find another place with the same problem.
Line 3628 in BookReader.js

It should be
+ "<form action='javascript:(function ($) {br.search($(\"#textSrch\").val());})(jQuery);' id='booksearch'><input type='search' id='textSrch' name='textSrch' val='' placeholder='Search inside'/><button type='submit' id='btnSrch' name='btnSrch'>GO</button></form>"

mangtronix (mang)
Changed in bookreader:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.