Comment 2 for bug 1847821

Reviewed: https://review.opendev.org/688214
Committed: https://git.openstack.org/cgit/openstack/blazar/commit/?id=0346b02ccea75b992d0b72a6dbaa1f05864450e0
Submitter: Zuul
Branch: master

commit 0346b02ccea75b992d0b72a6dbaa1f05864450e0
Author: Jason Anderson <email address hidden>
Date: Fri Oct 11 16:51:28 2019 -0500

    Fix issue moving hosts back to freepool

    If an aggregate fails to be created for some reason, for example because
    the requested node is not in the freepool, some cleanup occurs. Part of
    the cleanup is ensuring the target node is moved _back_ to the freepool.
    This should theoretically "heal" cases where the node wasn't in the
    freepool but also wasn't in some lease aggregate.

    However, this call to Nova's API refers to the freepool aggregate by its
    name, which is not supported here: the ID must be used[1]. This caused
    this operation to fail and raise a NotFound, confusingly (because Nova
    couldn't find an aggregate with ID='freepool' for example.)

    [1]:
    https://docs.openstack.org/api-ref/compute/?expanded=add-host-detail#add-host

    Closes-Bug: #1847821
    Change-Id: I7af4d407b183578617131f0de42becb3dc2bc415