Comment 4 for bug 1015564
Revision history for this message
| Kurt Smolderen (kurt.smolderen) wrote Re: Unity and Sound Menu support should be checked at runtime | #4 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Agree on that. But is leaving out any runtime check not dangerous as well? What if someone is running for example Xubuntu and has removed libunity. Beatbox will probably be installed via Launchpad PPA and hence will have Unity integration enabled... Now when Beatbox starts, it will crash because it can not load libunity...
So as suggested in "MPRIS2 doesn't work" (LP bug 1016369), I think the following is what needs to be done:
- Create MPRIS anyway (dbus is the only dependency, right?)
- Check for soundmenu when creating the MPRIS instance and only activate soundmenu support if soundmenu-indicator is running
- Check for unity process to be running before enabvling Unity integration support.
This way, soundmenu-indicator and unity become no requirement for running Beatbox... If you agree on this, I will update my branch and test the required behavior in Gnome Shell as well (sorry for not doing this on the first commit).