Comment 6 for bug 290030

Revision history for this message
Chow Loong Jin (hyperair) wrote : Re: [Bug 290030] Re: Do not scrobble (add to last.fm library) radio songs

On Sun, 2008-11-09 at 06:48 +0000, Alex Karpenko wrote:
> In an effort to move this along, I've patched banshee myself. I've attached a screenshot of what my change looks like. I am not fully satisfied with this solution, because as it turns out the original song reporting GUI option performed two tasks:
> 1. It reports a song as "Now Playing" to last.fm
> 2. It scrobbles the song when the song has finished playing
>
> It's probably sensible to decouple the two to allow the user to report
> all songs "now playing", but to scrobble only local tracks or only radio
> tracks or both. So I propose to change the Last.fm menu to contain the
> following options:
>
> Report Tracks as "Now Playing"
> Scrobble Local Tracks
> Scrobble Radio Tracks
>
> instead of the current "Enable Song Reporting" option which toggles all
> of the above at once.
>
> I'd like to get some input from banshee developers before I proceed with
> creating a patch.
>
> ** Attachment added: "screenshot.png"
> http://launchpadlibrarian.net/19504653/screenshot.png
>
It's awesome that you've created a patch for this. The developers
generally don't look in launchpad.net though. Could you post this in the
upstream bug tracker (bugzilla.gnome.org)? It's linked to this bug
already, at the top of this bug page.
--
Chow Loong Jin