Comment 4 for bug 1313689

Revision history for this message
Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c) wrote :

Hi Laurent,

Thanks for the feedback here ! For the second point, I think it's not necessary to have such a "default" rules. My args are:

 * First, a profil will at least have one rule to compute the account (and/or partner) so in any case the completion will provide one, even after this modification

 * If it is not the case anyway, why a rule must set the account_id on completion ? We have a default value for account_id through the _defaults = {'account_id': _get_default_account,} that call the get_values_for_line. The completion will only do the same a second time.

 * Entering the line manually will call the on_change of the bank_statement_ext and provide an account_id

So in the following use cases, I see no trouble,:

 * Entering a statement line manually with *_base_completion installed or not will set a default account_id
 * Importing lines with *_base_import installed and no account provided, the account_id will be set on completion following the rules as all of them at least give the account_id.

Do I miss one ?

Regards,

Joël